Feature #1020: Ability to choose subtitles - Tvheadend

Feature #1020

Ability to choose subtitles

Added by Andreas Lunderhage over 12 years ago. Updated about 7 years ago.

Status:

Fixed

Priority:

Normal

Assignee:

Category:

User Interface

Target version:

Start date:

2012-06-02

Due date:

% Done:

Estimated time:

Description

It would be nice to be able to configure which subtitle track to use for the vlc plugin in the WebUI.

Pretty annoying with finnish subs when I am swede and it is not even possible to turn them of.

Here are some examples how it is done:
http://forum.videolan.org/viewtopic.php?t=33190

So it is just about adding another parameter and burping it out in the player window.

Files

vlc_test.html (1.33 KB) vlc_test.html		Andreas Lunderhage, 2012-06-03 22:06
subtitles.patch (19.4 KB) subtitles.patch	Subtitle update	Andreas Lunderhage, 2012-06-07 21:21

History

Updated by Hein Rigolo over 12 years ago

can you come up with a patch that could implement this?
here is location where the vlc plugin gets called in the source:

/ src / webui / static / app / tvheadend.js

Hein

Updated by Andreas Lunderhage over 12 years ago

File vlc_test.html vlc_test.html added

I have spent the evening to find out how it works...

I have found out that the stream has to be started before it is possible to determine if we have subtitles, which ones and then set the one we want.

Then the question is how it should work in Tvheadend.

Either we can add another combo box to the player window in case the stream has subtitles. Or we can add a config parameter and then try to set that one if it is possible. Then we don't bloat the player window. I would prefer the later one.

What do you think?

Updated by Andreas Lunderhage over 12 years ago

File subtitles.patch subtitles.patch added

This is my suggestion about how it should be done.

I turning the subtitles off by default. Then I have added a button to cycle through the available subtitles including turning them off again. Also the active subtitles is shown in the video window for short moment so you know what you have chosen.

Only thing missing is an icon for the button, maybe it should be a "T"?

Updated by Hein Rigolo over 12 years ago

why a "T" ... and not a "S"?
Or how about a icon that is a square with a little line just above the bottom? (to mimic the position of the subtitles)
And can you set a tooltip for the icon?

Hein