Project

General

Profile

This project is closed and read-only.

Actions
Copy link

Feature #1020

closed

Ability to choose subtitles

Feature #1020: Ability to choose subtitles

Added by Andreas Lunderhage over 14 years ago. Updated almost 9 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
User Interface
Target version:
-
Start date:
2012-06-02
Due date:
% Done:

0%

Estimated time:

Description

It would be nice to be able to configure which subtitle track to use for the vlc plugin in the WebUI.

Pretty annoying with finnish subs when I am swede and it is not even possible to turn them of.

Here are some examples how it is done:
http://forum.videolan.org/viewtopic.php?t=33190

So it is just about adding another parameter and burping it out in the player window.

Files

Download all files
vlc_test.html (1.33 KB) vlc_test.html Andreas Lunderhage, 2012-06-03 22:06
subtitles.patch (19.4 KB) subtitles.patch Subtitle update Andreas Lunderhage, 2012-06-07 21:21

Updated by Hein Rigolo over 14 years ago Actions
Copy link
 #1

can you come up with a patch that could implement this?
here is location where the vlc plugin gets called in the source:

/ src / webui / static / app / tvheadend.js

Hein

Updated by Andreas Lunderhage over 14 years ago Actions
Copy link
 #2

I have spent the evening to find out how it works...

I have found out that the stream has to be started before it is possible to determine if we have subtitles, which ones and then set the one we want.

Then the question is how it should work in Tvheadend.

Either we can add another combo box to the player window in case the stream has subtitles. Or we can add a config parameter and then try to set that one if it is possible. Then we don't bloat the player window. I would prefer the later one.

What do you think?

Updated by Andreas Lunderhage over 14 years ago Actions
Copy link
 #3

This is my suggestion about how it should be done.

I turning the subtitles off by default. Then I have added a button to cycle through the available subtitles including turning them off again. Also the active subtitles is shown in the video window for short moment so you know what you have chosen.

Only thing missing is an icon for the button, maybe it should be a "T"?

Updated by Hein Rigolo over 14 years ago Actions
Copy link
 #4

why a "T" ... and not a "S"?
Or how about a icon that is a square with a little line just above the bottom? (to mimic the position of the subtitles)
And can you set a tooltip for the icon?

Hein

Updated by Adam Sutton almost 14 years ago Actions
Copy link
 #5

  • Category set to 11

Updated by Walter Purcaro almost 14 years ago Actions
Copy link
 #6

Patches are gone. :(

Updated by Adam Sutton almost 14 years ago Actions
Copy link
 #7

It's a bug in redmine (related to the upgrade) and Andreas is on the case.

Adam

Updated by Walter Purcaro almost 14 years ago Actions
Copy link
 #8

okay, meanwhile I'll try to make it alone. ;)

Updated by Andreas Lunderhage almost 14 years ago Actions
Copy link
 #9

What do you mean with "patches are gone"? It is in this thread. Then if it has made it's way to the repo yet, I don't know.

Updated by Adam Sutton almost 14 years ago Actions
Copy link
 #10

Andreas, see my note above it was a redmine bug which has now been fixed.

Adam

Updated by Walter Purcaro almost 14 years ago Actions
Copy link
 #11

Thanks :)

Updated by Sam Stenvall almost 12 years ago Actions
Copy link
 #12

@perexg I think you can close this, this is possible using stream filters nowadays.

Updated by Rob vh almost 12 years ago Actions
Copy link
 #13

@Walter: Please explain? How does the "wife" enable/disable these filters?

Updated by Mark Clarkstone almost 9 years ago Actions
Copy link
 #14

  • Status changed from New to Fixed

Sam Stenvall wrote:

@perexg I think you can close this, this is possible using stream filters nowadays.

As above :)

Actions
Copy link

Also available in: PDF Atom