Tvheadend

I would like to reopen this bug.

The above change fixes only the WebUI, but not the file name pattern %s for recordings.

I see your point.

Adding a new column and new % pattern for the summary text would be an equally good solution to me and would avoid further extension of the previous hack.

Jaroslav Kysela wrote:

There is no subtitle in EIT data. Previous version of tvh just make a copy of the summary text to the subtitle, but it's not correct.

The epg shows subtitle, so the eit has it (and I confirmed that with other tools), and that was also used in the dvr settings, but not anymore.
I can understand that some providers don't set it, but most do. Shouldn't that take precedence over any other info gleaned from guessing at description fields?

EPG grid shows summary when subtitle is empty (see the new header description). Something similar should be added for DVR, but I'm working on other things at the moment.

I get what you're trying to do.
Only I fear that an advanced (as in nice to have) feature is currently breaking a working basic feature.

Shouldn't a newly commited feature attempt be rejected if it breaks an existing and working basic feature?

I don't know if this issue was already fixed, but after I recreated all autorecs out of the EPG all subtitles were also shown in the upcoming recordings tab. Even the duplicates from the finished recordings where filtered.

I will wait, if the next recordings will be successful and the subtitle will be added to the filename. And if the future recordings after a epg update will also show the subtitle.

+1 to buggy-in-usage.
The working not-correct feature should not removed before "correct" feature runs.
It's fact that now there's no recording of series possible as the files are only counted "Stargate SG1 - 1.ts" -2, -3, etc. Until December the subtitles where in the filename.

1) You could provide an option field for old/new habit in Recording-profile
2) I understand the changeset above as: "summary" should not fill in for "subtitle". So: Add the action to save "summary" to disk instead als .eit-file with same filename to your changeset.

Edit: possibly faulty "summary" should not fill in for "subtitle" is what I understood out of your changeset.

It's definitely bug to "propagate" directly and blindly a copy of summary to subtitle field from the EPG grabber to the upper layers. The commit which removed this (by default) is https://github.com/tvheadend/tvheadend/commit/9b40e5a26915161e6904001154afdb3e68de49d0 , so as you can see, it's possible to revert to the old behaviour in the EIT config by checking one checkbox.

I'm working on a proper solution (will be released probably tomorrow, because other code cleanups).

Jaroslav Kysela wrote:

...
revert to the old behaviour in the EIT config by checking one checkbox.

I need to find that config, didn't know that existed (or forgot about it)

This is still broken.

The fact that it got rejected tells me that the subtitle feature is gone in favor of something that noone understands and can use except maybe the author.
This renders the dvr pretty much useless for series recordings for normal mortals.