Feature #6227
closedBuild in icam patches?
0%
Description
Is it possible to build in these patches please?
Files
Updated by Chris G over 2 years ago
Flole Systems wrote:
Please submit a PR for it.
Hello. Sorry but I am not sure how. This isn't my work. It was posted by a guy called fegol on the linuxsat-support forum. I have been using it for some weeks now and it seems to work fine.
Updated by Flole Systems over 2 years ago
By using the functionality on GitHub. That's the only way patches are reviewed and merged.
Updated by saen acro over 2 years ago
@ Chris G before this patch is applyed need to make libdvbcsa download (as ffmpeg)
Updated by Flole Systems over 2 years ago
saen acro wrote:
@ Chris G before this patch is applyed need to make libdvbcsa download (as ffmpeg)
No we won't statically build libdvbcsa, that patch needs to be submitted upstream and merged there.
Updated by saen acro over 2 years ago
Flole Systems wrote:
saen acro wrote:
@ Chris G before this patch is applyed need to make libdvbcsa download (as ffmpeg)
No we won't statically build libdvbcsa, that patch needs to be submitted upstream and merged there.
To be clear both patches are interconnected
Except... if some one move patched code from LIBDVBCSA to TVHCSA
and solve this little problem.
Updated by Hanspeter Müller over 2 years ago
This patch requires the patched libdvbcsa, otherwise compilation will fail, it would need compile-time detection or a switch for the new lib.
libdvbcsa is 15 years old, with the last real change six years ago. Don't hold your breath that they integrate the patch upstream anytime soon, or ever, it's technically against the CSA-Specs, and more important, you can only use it with a paid cardsharing-server. Using uncertified hardware with your own subscription-card is in a legal grey-area in most countries, but cardsharing is not!
/hp
Updated by Flole Systems over 2 years ago
Well it would have to pass CI before it gets merged anyways. If the libdvbcsa version that the CI server uses doesn't have the patch (it's a recent Ubuntu) such issues would be detected early enough.
Anyways: If this is abandoned by the author I will close this soon.
Updated by Chris G over 2 years ago
This is abandoned. I was just making the suggestion. If you don't want to do it then close the issue.
Updated by Flole Systems over 2 years ago
- Status changed from New to Rejected
Due to lack of resources feature requests will only be accepted if the author will work on it.
Updated by Pim Zandbergen about 2 years ago
Submitted PR https://github.com/tvheadend/tvheadend/pull/1501