Tvheadend

Flole Systems wrote:

Please submit a PR for it.

Hello. Sorry but I am not sure how. This isn't my work. It was posted by a guy called fegol on the linuxsat-support forum. I have been using it for some weeks now and it seems to work fine.

By using the functionality on GitHub. That's the only way patches are reviewed and merged.

@ Chris G before this patch is applyed need to make libdvbcsa download (as ffmpeg)

saen acro wrote:

@ Chris G before this patch is applyed need to make libdvbcsa download (as ffmpeg)

No we won't statically build libdvbcsa, that patch needs to be submitted upstream and merged there.

Flole Systems wrote:

saen acro wrote:

@ Chris G before this patch is applyed need to make libdvbcsa download (as ffmpeg)

No we won't statically build libdvbcsa, that patch needs to be submitted upstream and merged there.

To be clear both patches are interconnected

Except... if some one move patched code from LIBDVBCSA to TVHCSA
and solve this little problem.

This patch requires the patched libdvbcsa, otherwise compilation will fail, it would need compile-time detection or a switch for the new lib.

libdvbcsa is 15 years old, with the last real change six years ago. Don't hold your breath that they integrate the patch upstream anytime soon, or ever, it's technically against the CSA-Specs, and more important, you can only use it with a paid cardsharing-server. Using uncertified hardware with your own subscription-card is in a legal grey-area in most countries, but cardsharing is not!

/hp

Well it would have to pass CI before it gets merged anyways. If the libdvbcsa version that the CI server uses doesn't have the patch (it's a recent Ubuntu) such issues would be detected early enough.

Anyways: If this is abandoned by the author I will close this soon.

This is abandoned. I was just making the suggestion. If you don't want to do it then close the issue.

Submitted PR https://github.com/tvheadend/tvheadend/pull/1501

I submitted a new PR. It uses dlopen() and dlsym() to detect whether libdvbcsa is patched at runtime.
This means tvheadend will both build and run on either standard or patched libdvbsa.

Pim Zandbergen wrote:

I submitted a new PR. It uses dlopen() and dlsym() to detect whether libdvbcsa is patched at runtime.
This means tvheadend will both build and run on either standard or patched libdvbsa.

To be correct libdvbcsa is no patched with latest Specs from DVB.org
https://code.videolan.org/videolan/libdvbcsa/-/commits/master?ref_type=heads
is updated Nov 23, 2016 but world not stop to rotate from that date.

It's true; Fedora uses the videolan.org version for its libdvbcsa distribution, yet the ICAM libdvbcsa patches are based on https://github.com/glenvt18/libdvbcsa
I suppose many other distributions use the videolan.org version.
It would be interesting if someone could make similar patches to the official videolan.org version.
It's not really relevant, though, it is up to the user to choose which libdvbcsa to use, and with my latest PR, tvheadend will be happy to use any version.

Hanspeter Müller wrote:

you can only use it with a paid cardsharing-server. Using uncertified hardware with your own subscription-card is in a legal grey-area in most countries, but cardsharing is not!

I am pretty sure people are patching their software in order to decode using local cards