Tvheadend

Which .c file causes this problem? The pthread_mutex_t should not be used anywhere in tvh except in the tvh_thread.c.

CC              src/main.o
In file included from src/main.c:19:0:
/home/buildroot/br5/output/build/tvheadend-771dfd6bea7bd4035ed991eccbe735dc00d3f800/src/tvh_thread.h:163:25: error: unknown type name ‘__do_not_use_pthread_mutex_t’
 #define pthread_mutex_t __do_not_use_pthread_mutex_t
                         ^

main.c does not use pthread_mutex_t . It apears like a compiler issue.

src/main.c includes tvh_thread.h in line 19:
https://github.com/tvheadend/tvheadend/blob/master/src/main.c#L19

This header file in line 163 has the code which is broken on uClibc:
https://github.com/tvheadend/tvheadend/blob/master/src/tvh_thread.h#L163

This line is only included when TVH_THREAD_C is not defined.

TVH_THREAD_C is only defined in tvh_thread.c but not in main.c which seems
to me the cause of the problem. I see two possible solutions here:
- delete at least line 163 from tvh_thread.h
- add "#define TVH_THREAD_C 1" to main.c (and tvhlog.c & tvh_locale.c)

If you agree on either one of these solutions I will send a patch.

You've not got the point. It's only define, so if the pthread_mutex_t is not used in the code (and it should not be used in main.c) then the compilation error should not occur because of the forced invalid symbol (and yes - it's defined by purpose to catch all occurences of pthread usage to not mix the special tvheadend mutex code). I don't see anything from your report why uclibc compilation ends with such error. So again, where is the pthread_mutex_t symbol used when main.c is being compiled?

You may use 'gcc -E' and inspect the source code after the preprocessor run to get an overview where is pthread_mutex_t used in uclibc.

This line is included during the build of main.c:
https://git.uclibc.org/uClibc/tree/libc/sysdeps/linux/common/bits/uClibc_stdio.h#n214

What about to include uclibc's stdio.h before tvheadend's header files? It would be probably nice to make those hacks visible using #ifdef like:

#ifdef __UCLIBC_HAS_THREADS__
#include <stdio.h> /* uses pthread_mutex_t */
#endif

Jaroslav Kysela wrote:

What about to include uclibc's stdio.h before tvheadend's header files?

Thx, this fixes the problem for me, sent PR: https://github.com/tvheadend/tvheadend/pull/1283