Project

General

Profile

Bug #4872

Please reopen issue 4816

Added by Robin Mitra almost 7 years ago. Updated almost 7 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Category:
EPG
Target version:
-
Start date:
2018-01-19
Due date:
% Done:

100%

Estimated time:
Found in version:
4.3-988~g9df7b94
Affected Versions:

Description

DVR subtitles is still broken.

The fact that issue 4816 got rejected tells me that the subtitle feature is gone in favor of something that noone understands and can use except maybe the author.
This renders the dvr pretty much useless for series recordings for normal mortals.

History

#1

Updated by Jaroslav Kysela almost 7 years ago

What does not work for you? DVR entries have new 'summary' column which should contain the text which was originally copyied to the subtitle field in the EIT grabber. The '%s' for pre/post processing scripts is using the summary when subtitle is empty (so the behaviour is same as previously) and new format strings were added to handle subtitle and summary texts separately.

#2

Updated by Mark Clarkstone almost 7 years ago

I have a few comments about the feature as well, which I'll add to the existing ticket :).


off-topic:

Was there a need to open another issue requesting an old one be opened? I understand your annoyance that a feature doesn't work for you, but a single message in the existing issue would've had the same effect.

Regardless of an issue's status any replies will be sent to those involved.

#3

Updated by Robin Mitra almost 7 years ago

What issues I have?
- first of all naming. A subtitle is a subtitle and not a summary. A summary suggests one or more sentences decribing the event. I wouldn't want a file to be named with a paragraph of text (if that is even possible).
- secondly the implemetation. Right now the inmplementation has broken a working system.
- thirdly, what is 'summary'? where does it come from?
IIRC there are 3 things an eit provides (actually should provide, according to standard, although some are optional):
short event desc name (title)
short event desc text (subtitle), in the feeds I subscribe to (Astra 19.2 DACH channels), this is always episode name for series
opt. extended desc - description, or maybe that is what you're referring to as summary

If the feature is intended to fill in a missing subtitle from a summary, then it should fill in the known field subtitle and not replace or worse, rename it. In doing so, maybe apply some magic to limit the subtitle to a reasonable value that can used as part of a file name.

Right now, the web gui only shows non-empty 'subtitle or summary' or only summary.
Also, right now, this change breaks e.g. the KODI client, since the latter now cannot fill in the episode name /subtitle.

I can see additional issues being created with more or less the same complaint.

I reverted back to a commit before this change to verify that everything was indeed working, and yes, it does.
While doing so, I noticed that something wrt. channel names has also changed such that I couldn't use the latest config (almost all channel names where gone, showing 'name not present'). I had to restore an old backup.

The other thing I noticed was that epg grabbers do not start or stop immediately, but that has it's own issue.

#4

Updated by Jaroslav Kysela almost 7 years ago

Ok, if you like to be too much strict, here are description from EIT spec:

ETSI EN 300 468 V1.11.1 (2010-04)

6.2.37
Short event descriptor
The short event descriptor provides the name of the event and a short description of the event in text form.

6.2.15
Extended event descriptor
The extended event descriptor provides a detailed text description of an event, which may be used in addition to the
short event descriptor. More than one extended event descriptor can be associated to allow information about one event
greater in length than 256 bytes to be conveyed. Text information can be structured into two columns, one giving an
item description field and the other the item text. A typical application for this structure is to give a cast list, where for
example the item description field might be "Producer" and the item field would give the name of the producer.

So, I don't know where you got the 'subtitle' in EIT standard. I a bit inherited 'summary' from the previous development (it's not my idea), but basically, the abstraction in tvh is:

1) title
2) subtitle (short title extension, like episode name)
3) summary (short event description)
4) description (long event description)

The many tvh versions filled only summary from EIT data (from the short event), but laster, there was added forced duplication (the summary was copied to subtitle). It's unfortunately not so much correct (information is lost). Recently, we added regex scraping (so you can rewrite the EIT data using regex rules).

Right now, the web gui only shows non-empty 'subtitle or summary' or only summary.

UI shows all info (subtitle or summary in the grid and subtitle and summary in the EPG info dialog).

Also, right now, this change breaks e.g. the KODI client, since the latter now cannot fill in the episode name /subtitle.

Good point. It should be fixed for old (current) clients.

I can see additional issues being created with more or less the same complaint.

I don't see them. All the code works like previously - when subtitle is not set (regex scraped for EIT), the summary is used. So user will get the same text.

I reverted back to a commit before this change to verify that everything was indeed working, and yes, it does.

As I already wrote, there's a switch in the EIT grabber which will copy summary to subtitle (so the old import behaviour is configurable). Configuration / Channel/EPG / EPG Grabber Modules - select 'EIT: DVB Grabber' - 'Set subtitle to summary' .

#5

Updated by Robin Mitra almost 7 years ago

I think that's where things went wrong.
The short event text (or description) is the what is usually the subtitle (or episode name)
That's how it used to work until mid-dec, and that is how other dvr's I know of work (WMC, dvbviewer, imho even dvblogic)

The long event is, well, a longer description and is normally used to populate any 'description' fields.

Now it got renamed to 'summary' and everything's getting confused.

#6

Updated by Jaroslav Kysela almost 7 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset commit:tvheadend|9bdd7470d0bec377f70cf4fb673896ad8e8a659a.

Also available in: Atom PDF