Project

General

Profile

Bug #3541

Use Windows-compatible filenames

Added by Adriano Catapano almost 9 years ago. Updated almost 9 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Category:
PVR / DVR
Target version:
-
Start date:
2016-01-29
Due date:
% Done:

100%

Estimated time:
Found in version:
4.0.8-3~gc870eb9
Affected Versions:

Description

In "Digital Video Recorder Profiles" there is a useful option "Use Windows-compatible filenames" who does his job but does not control the length of the file name that should not exceed 255 characters and have a maximum of 260 for the full path.

History

#1

Updated by Jaroslav Kysela almost 9 years ago

I was not aware about the 260 characters limit in windows.. Really silly implementation of the filesystem.

The maximum filename length checking is resolved in the 4.1 code.

#2

Updated by Adriano Catapano almost 9 years ago

We are talking about windows, the file system is not the most serious problem.

Version 4.1 is not in release/stable build type?

#3

Updated by Jaroslav Kysela almost 9 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset commit:tvheadend|cfbda5eb55cf368b619a24394071469b9947c96a.

#4

Updated by Jaroslav Kysela almost 9 years ago

I hardcoded the 255 filename limit for 4.1 when use windows compatible filenames is active (because pathconf(filename, _PC_NAME_MAX) returns a large value for VFAT -unicode characters, so it's unusable).

The directory path handling is more difficult (check the mountpoint for vfat). I would suggest to handle this at the administrator level (ensure that the total filename length won't cross this limit - I added $99t and $99s format strings for title/subtitle where 99 is the limit number - 99 is only example - for the filename specification).

Also available in: Atom PDF