Project

General

Profile

Bug #3434

Setting Maximum Count Does not clean up old recording

Added by Scott Harris almost 9 years ago. Updated almost 9 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Category:
PVR / DVR
Target version:
-
Start date:
2015-12-23
Due date:
% Done:

100%

Estimated time:
Found in version:
4.1-1246~gdc4e037
Affected Versions:

Description

I have set maxiumum count on an autorec entry and it has no effect on cleaning up entries greater than the setting.

History

#1

Updated by Scott Harris almost 9 years ago

On further testing the delete function is working, the problem was on update of the autorec timer the existing recordings are not counted towards the total.

ie
- create autorec and let it record 5 shows
- update autorec and set max count to 5
- record another show and expecting oldest to be deleted but does not because the count is now only 1, the first 5 recorded shows are not counted in the total due to the autorec timer update.

when the autorec timer is updated is it possible to update existing recordings so they are counted?

#2

Updated by Jaroslav Kysela almost 9 years ago

Only entries added by autorec are managed by autorec rules. Other entries are standalone. I don't think it's a bug.

#3

Updated by Scott Harris almost 9 years ago

Jaroslav Kysela wrote:

Only entries added by autorec are managed by autorec rules. Other entries are standalone. I don't think it's a bug.

Sorry will explain again with more details.

I set up an autorec and let it record 2 shows, I then go and update the autorec and change the max count from 0 to 2. It then records another show for a total of 3, I expect the oldest to be deleted but it does not.

If I check the contents of the log files for each of the 3 only the last has a value set for the autorec entry.

Looking in the code when an autorec entry is updated and saved in dvr_autorec_entry_class_save, dvr_autorec_changed(dae, 1); is called which does a purge on the existing recordings which is why old entries are missing the autorec entry.

I can submit a pull request is change to dvr_autorec_changed(dae, 0); but not sure if that's the correct way to fix.

Scott

#4

Updated by Jaroslav Kysela almost 9 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset commit:tvheadend|697512934a1f1069cb3d5756f3bb170b9527fb46.

#5

Updated by Jaroslav Kysela almost 9 years ago

I see now. Fixed in v4.1-1257-g6975129 .

Also available in: Atom PDF