Bug #307
closed
Added by sbi - over 14 years ago.
Updated over 14 years ago.
Description
Hi,
I believe there is a bug in the mkv muxer related to aspect ratios.
Indeed, it seems to me that the aspect ratio written as Display Aspect Ratio in the mkv files is actually the Samble Aspect Ratio that comes from the h264 stream. This is not always correct.
The attach patch is an attempt to fix this.
-sbi
Files
Hm, I know this is a problem for h264. But for mpeg2 I think it does the correct thing?
- Found in version set to fixed
Fixed differently in r5478.
Please verify that it works :-)
- Status changed from Fixed to Need feedback
- Found in version deleted (
fixed)
Almost. This should take care of interlacing:
diff --git a/tvheadend/src/parser_h264.c b/tvheadend/src/parser_h264.c
index 1114f7e..3833049 100644
--- a/tvheadend/src/parser_h264.c
+++ b/tvheadend/src/parser_h264.c
@ -410,8 +410,8 @ h264_decode_slice_header(th_stream_t *st, bitstream_t *bs, i
if(p->sps[sps_id].aspect_num && p->sps[sps_id].aspect_den) {
- int w = p->sps[sps_id].aspect_num * p->sps[sps_id].width;
- int h = p->sps[sps_id].aspect_den * p->sps[sps_id].height;
+ int w = p->sps[sps_id].aspect_num * st->st_width;
+ int h = p->sps[sps_id].aspect_den * st->st_height;
int d = gcd(w, h);
st->st_aspect_num = w / d;
- Status changed from Need feedback to Fixed
- Found in version set to fixed
Also available in: Atom
PDF
Updated by 
Updated by sbi -