Bug #2921
Improvements to PVR after last changes
100%
Description
Last time, connection limit has been introduced to PVR. After this change I notice few thing that could be improved IMHO:
1) Some users might want to not limit DVR sessions, so it might be a good idea, to implement another check box in Access Entries, to tell TVH if connection limit should be applied to DVR too.
2) When connection limit is exhausted, recording fails with "File not found". This message says nothing about connection limit and should be changed.
3) Users without "All DVR" right set, should not see recordings scheduled (owned) by other users. I think that "Video Recorder" and "HTSP DVR" should allow owner of recording to play/download/remove it, but he should not see recordings owned by others. When "All DVR" right is granted, then the user should be able to see and playback recordings owned by others, and only with "All DVR (rw)" granted, he should be able to delete recordings owned by everyone.
History
Updated by Jaroslav Kysela over 9 years ago
Updated by Implemented 1) and 2), but 3) should work as you described.
Are you sure that you have ACLs set correctly ? Note that the rights are "merged" also for the network ranges, so if you set "All DVR" for some IP range, the users connection from this range will have this permission, too. Anyway, "--trace access" should print the actual priviledges to check if the problem is in the condition in the code.
Updated by Rafal Kupiec over 9 years ago
Updated by I have few users with the same subnet defined. That might be the reason why it is not working as described.
What is the reason to merge privileges for network range?
Updated by Jaroslav Kysela over 9 years ago
I meant "anonymous user ranges" (users with usernames "*"). I think that it's logical to authentizate through IP or username/password. It would be a bit inconsistent that an IP authentization (anonymous) might have better priviledges than username/password authentization, wouldn't ?
Updated by Rafal Kupiec over 9 years ago
Sounds good, but actually I got troubles with testing this TBH.
When I schedule recording as administrator via webui, then it records fine. When I schedule recording from Kodi as a regular user, then it fails with "missing file"...
Updated by Rafal Kupiec over 9 years ago
Indeed:
I have set Conenction Limit Type to Streaming and Limited connection to 1.
When it fails with "missing fale" the logs says:
2015-06-05 22:05:18.087 [ ERROR]:dvr: multiple connections are not allowed for user 'belliash' from 'belliash' (limit 1, streaming 1, active DVR 1)
so point 2 is still not implemented, and looks like point 1 is buggy 
Updated by Rafal Kupiec over 9 years ago
Jaroslav Kysela wrote:
Both issues are fixed now. v4.1-165-gf101b85
Now fails with "User limit reached" error and after setting limit to streaming only then it also fails with the following error in log:
2015-06-05 22:33:03.601 [ ERROR]:dvr: multiple connections are not allowed for user 'belliash' from 'belliash' (limit 1, dvr limit 0, active DVR 1, streaming 1)
Updated by Rafal Kupiec over 9 years ago
Rafal Kupiec wrote:
Jaroslav Kysela wrote:
Both issues are fixed now. v4.1-165-gf101b85
Now fails with "User limit reached" error and after setting limit to streaming only then it also fails with the following error in log:
2015-06-05 22:33:03.601 [ ERROR]:dvr: multiple connections are not allowed for user 'belliash' from 'belliash' (limit 1, dvr limit 0, active DVR 1, streaming 1)
Also, I think this is bad conception, because ppl who has limited both streaming and dvr, should be still able to launch kodi and begin recording... they are just connected to TVH, but not streaming/recording anything
Updated by Rafal Kupiec over 9 years ago
Jaroslav Kysela wrote:
Another thinko fixed in 166.
still no help
Updated by Jaroslav Kysela over 9 years ago
- Status changed from New to Fixed
- % Done changed from 0 to 100
Applied in changeset commit:tvheadend|5cc371720334e889a3879f76ce6cf3c664b85709.