Bug #1622
Crash when changing channel with Timeshift enabled
0%
Description
./tvheadend: version 3.5.2~gc338802
Timeshift enabled, On Demand off Unlimited size off TVH crashes when you change channels. 500 limit crashed on first channel change, Increased to 5000 crashes on second channel change. Not hitting pause at any time, just playing.
./configure --> http://pastebin.com/GkFCa2Em
Timeshift config --> http://pastebin.com/79N5GJgt
tvheadend d -l -> http://pastebin.com/HHXnzbTj
gdb tvheadend core --> http://pastebin.com/7QbXjJsp
History
Updated by Adam Sutton over 11 years ago
Updated by - Status changed from New to Accepted
Yeah I think I can see what's going on there. To be honest I really should simplify that code, but I'll probably just patch things for now and I'll look at some more improvements post 3.4. Though I know Andreas has some other ideas for this as well.
Adam
Updated by Adam Sutton over 11 years ago
- Category set to Timeshift
- Assignee set to Adam Sutton
Can you try this, http://pastebin.com/Qva6dQ0b, I can definitely see there is a failure to properly check things and it could be trying to double remove stuff from lists (not good).
However I cannot entirely see (given your config) how it could have gotten into the particular scenario. If you get another crash can you provide the same info, i.e. gdb bt full output with corresponding log.
Adam
Updated by Ron L over 11 years ago
Updated by I applied the patch but it's still not a happy camper. Crashes on the second channel change as before.
Same configs
debug log --> http://pastebin.com/RNDe8Gkj
gdb trace --> http://pastebin.com/DMgXBVJp
Updated by Adam Sutton over 11 years ago
Yeah missed another NULL check, http://pastebin.com/RtNbgs7g.
However this still implies that you're reaching the end of the buffer. Which I'm not sure is right either (might be some odd channel change condition I've not thought about).
Adam
Updated by Ron L over 11 years ago
Alright, that patch has stopped the crash on channel change. It now goes straight to ts buffer full. The buffer dir is created, but no 0,1,2 etc dirs get created and no tvh- buffer files are written.
Same configs.
debug log --> http://pastebin.com/z4wAKEXH
Updated by Ron L over 11 years ago
Ron L wrote:
Alright, that patch has stopped the crash on channel change. It now goes straight to ts buffer full. The buffer dir is created, but no 0,1,2 etc dirs get created and no tvh- buffer files are written.
Same configs.
debug log --> http://pastebin.com/z4wAKEXH
No, sorry I was mistaken. It writes a buffer/0 dir and tvh- buffer files. Sometimes it will also write a buffer/1 dir as well. What I've noticed and I'm not sure if this is correct behaviour is that the first /buffer/1/tvh-file will have the same name as the last /buffer/0/tvh-file. On the next channel change it starts going to ts buffer full and no more tvh- files are written.
Updated by Adam Sutton over 11 years ago
The file naming sounds right, the names are based on the (monotonic) system clock, so most of the time when channel surfing you will see same name for last of old sub and first of new sub.
But definitely something not right there, I'll try and take a look later today.
Adam
Updated by Adam Sutton over 11 years ago
- Status changed from Accepted to Fixed
Ron,
I'm closing this I believe the original issue is fixed and I simply cannot reproduce the immediately to full issue, but please submit that as a separate bug if its still happening with master.
Adam