Project

General

Profile

Bug #1605

Timeshift not deleting files until you stop playback.

Added by Ron L over 11 years ago. Updated over 11 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Category:
Timeshift
Target version:
-
Start date:
2013-02-14
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Found in version:
3.3.461~g0fd2aaf
Affected Versions:

Description

./tvheadend: version 3.3.461~g0fd2aaf
XBMC Media Center 12.0 Git:fb595f2

Still having some issues with Timeshift. On demand set to off it will write buffer files until it hits the Max size limit. Once it hits the limit it stops writing files. It doesn't delete old files to keep from hitting the limit. When you stop play it deletes all the files in the buffer, but when you start play again it doesn't start writing to the buffer again until you restart tvheadend. If you set unlimited it writes until the drive is full, doesn't delete any old files until you stop play and won't write to the buffer again until you restart tvheadend.

With On demand enabled it starts writing files when you hit pause, when you hit play again it does delete old buffer files but with Max limit set only keeps writing until the end of the current tvh- file then stops. It won't write buffer files again until you restart tvheadend. On demand enabled and unlimited set works unless you leave it on pause too long and it fills up the drive. Then it also stops writing files to the buffer until you restart tvheadend.

Not crashing any more though, so that is good.


Subtasks

Bug #1619: Timeshift indicates buffer fullInvalidAdam Sutton

Actions

History

#1

Updated by Adam Sutton over 11 years ago

I have just realised that I think this might have been something I identified as an issue from the start and then completely forgot about, doh!

At least if the buffer is paused such that it reaches its limit it will then "freeze" the buffer and will not do anything more until you unsubscribe and re-subscribe (i.e. channel up/down etc..)

HOwever I'm not sure that's exactly what you're describing so I will double check.

#2

Updated by Adam Sutton over 11 years ago

  • Status changed from New to Accepted

Yeah definitely something wrong, I need to investigate further.

Adam

#3

Updated by Adam Sutton over 11 years ago

OK, I think I understand what's going on. When it reaches the limit it should mark the oldest file for removal. However the file isn't actually removed until later (its done in another thread incase of slow file removal) and this is where the used space is reduced. This is the error, the space needs to be marked as free at the point hte file is marked for removal.

I still need to do some checking and post a fix.

Adam

#4

Updated by Adam Sutton over 11 years ago

  • Status changed from Accepted to Fixed

Applied in changeset commit:8b8876d768a693d3a6a8dbd0939268605e509407.

Also available in: Atom PDF