Project

General

Profile

This project is closed and read-only.

Actions

Bug #1596

closed

Generation on debian fails because of Version = -unknown in control file

Bug #1596: Generation on debian fails because of Version = -unknown in control file

Added by Eric Valette over 13 years ago. Updated over 13 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
General
Target version:
-
Start date:
2013-02-04
Due date:
% Done:

100%

Estimated time:
Found in version:
v3.3-453-g5dd5826
Affected Versions:

Description

reading the script I found the command run and tested it manually

git describe --dirty --match 'v*'
v3.3-453-g5dd5826

but

sh support/version
-unknown

sh x support/version
+ FILE=
+ '[' -d .git ']'
++ dirname support/version
+ cd support
+ git describe --dirty --match 'v*'
VER=
+ '[' 128 -ne 0 ']'
++ dirname support/version
+ cd support
+ git describe --match 'v*'
VER=-unknown
+ echo -unknown
+ sed 's/^v//'
+ sed 's/
\([0-9]*\)-\(g[0-9a-f]*\)/.\1~\2/'
VER=-unknown
+ '[' -z '' ']'
+ echo -unknown
-unknown
+ exit

Updated by Eric Valette over 13 years ago Actions #1

In fact the cd $(dirname $0) cause the problem.

Updated by Adam Sutton over 13 years ago Actions #2

I don't understand, the debug above shows that command succeeded (and git ops should work from any valid subdir of the repo). I've checked this on a wheezy build system, its all I've got access to. It works fine.

What output do you get it you manually run:

cd support
git describe --dirty --match 'v*'

Adam

Updated by Eric Valette over 13 years ago Actions #3

Adam Sutton wrote:

I don't understand, the debug above shows that command succeeded (and git ops should work from any valid subdir of the repo). I've checked this on a wheezy build system, its all I've got access to. It works fine.

What output do you get it you manually run:

cd support
git describe --dirty --match 'v*'

Adam

cd tvheadend/support/
113 r-x-ceva6380:~/local/src/tvheadend/support->git describe --dirty --match 'v*'
fatal: No names found, cannot describe anything.

Updated by Eric Valette over 13 years ago Actions #4

The same command in the root directory succeeds

Updated by Eric Valette over 13 years ago Actions #5

Eric Valette - wrote:

The same command in the root directory succeeds

113 r-x-ceva6380:~/local/src/tvheadend/support->git describe --dirty --match 'v*'
fatal: No names found, cannot describe anything.
114 r-x-ceva6380:~/local/src/tvheadend/support->cd ..
115 r-x-ceva6380:~/local/src/tvheadend->git describe --dirty --match 'v*'
v3.3-453-g5dd5826-dirty

Updated by Adam Sutton over 13 years ago Actions #6

Must be a problem with some old version of git I guess, easy enough to mod the script to switch to the root DIR instead. I'll post a fix later.

Adam

Updated by Eric Valette over 13 years ago Actions #7

Adam Sutton wrote:

Must be a problem with some old version of git I guess, easy enough to mod the script to switch to the root DIR instead. I'll post a fix later.

Adam

git --version
git version 1.8.1.1

Updated by Adam Sutton over 13 years ago Actions #8

Well that's newer than mine, so maybe its the reverse, they've now stopped allowing that. But that's not what I would have expected. All seems odd, but either way I'll mod the script to keep it happy.

Adam

Updated by Adam Sutton over 13 years ago Actions #9

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset commit:ac36914b986dfdab80d1243344f1b9a5b97a6247.

Actions

Also available in: PDF Atom