Bug #1574
imagecache does not support https located icons
100%
Description
When setting the icon location to github https, icons cannot be cached by tvh.
Files
History
Updated by Adam Sutton almost 12 years ago
Updated by - Status changed from New to Need feedback
Interesting, I've just checked this and I cannot replicate. I have tried downloading images from gravatar and github using https and both were fine.
The only thing that didn't work for me is from one of my own servers that uses self-signed certs and certificate validation is enabled by default.
Can you provide an example URL that you are finding does not work.
Adam
Updated by Carlo Landmeter almost 12 years ago
Updated by Does tvh curl try to validate the cert? If so i probably need ca-certificates installed (which i have not).
Updated by Adam Sutton almost 12 years ago
Yes, cert validation is enabled by default. We could disable it, I'm not sure its a massive security issue for this particular feature. But I'd rather not unless we need to (would probably make it user configurable option if required).
Adam
Updated by Carlo Landmeter almost 12 years ago
Could a configure switch be optional? else ill have to add it to deps in our repository.
Updated by Adam Sutton almost 12 years ago
It's possible, though might as well make it run-time configurable. Try attached patch first just to check it works.
Adam
Updated by Adam Sutton almost 12 years ago
- Status changed from Need feedback to Fixed
- % Done changed from 0 to 100
Applied in changeset commit:53a9d6a4baa3eb9ee7415e46ee6b8612d962a343.
Updated by Carlo Landmeter almost 12 years ago
Thanks for the fix.
Last week I tried your patch, but run into issues when I run XBMC v12 with the updated pvr addon. When I turn on imagecaching then it doesn't seem to work anymore.
It worked with the older pvr addon, but it seems the one that should have support for it (which i read in the pvr changelog) it doesn't.
I tried it both on OpenELEC and Windows version. Should i create a separate bug for it?