Project

General

Profile

Bug #1569

Cleaning file name chars does not remove ' ( single quote ) from DIRECTORY names. Painful in linux command lines

Added by Mark Kirkpatrick almost 12 years ago. Updated almost 12 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Adam Sutton
Category:
PVR / DVR
Target version:
3.4
Start date:
2013-01-23
Due date:
% Done:

100%

Estimated time:
Found in version:
3.3.380~gc1312e1-dirty
Affected Versions:

Description

I'm a bit rusty but i tracked this back to dvr/dvr_rec.c in function:
static void
cleanupfilename(char *s, int dvr_flags)

I added the s[i] == '\'' || to my copy to get rid of the single quotes blowing up my postprocess scripts. I think single quotes should be included in the "bad" character list for directories as well as files see below:

./Martha-Stewart's-Cooking-School/Martha-Stewart_s-Cooking-School.2013-01-20.E09.ts
./Martha-Stewart's-Cooking-School/Martha-Stewart_s-Cooking-School.2013-01-21.E10.ts
./Martha-Stewart's-Cooking-School/Martha-Stewart_s-Cooking-School.2013-01-22.E11.ts

I pass these files to a perl script to fire up comskip (linux compiled) process the raw MPEG_TS and then handbrake to get good quality small mkv files with closed captions still present and commercial cut lists to use in XBMC.

Files

dvr_rec.c (14.2 KB) dvr_rec.c Mark Kirkpatrick, 2013-01-23 20:51

History

#1

Updated by Mark Kirkpatrick almost 12 years ago

Forgot to mention when you have selected store by title and the title has an apostrophe ... see example above.

#2

Updated by Adam Sutton almost 12 years ago

  • Status changed from New to Accepted
  • Target version set to 3.4

Agree, title cleanup needs to be done for both file and dir names.

Adam

#3

Updated by Adam Sutton almost 12 years ago

  • Status changed from Accepted to Fixed
  • % Done changed from 0 to 100

Applied in changeset commit:43ae54c062edfbe0bd9dbfc07471484d151ef649.

Also available in: Atom PDF