Project

General

Profile

Bug #1454

bundle - strtok() race in fb_opendir()

Added by Jaroslav Kysela about 12 years ago. Updated about 12 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Adam Sutton
Category:
General
Target version:
3.2
Start date:
2012-12-12
Due date:
% Done:

100%

Estimated time:
Found in version:
current git
Affected Versions:
3.2, 3.3

Description

I experience a re-entrant race in fb_opendir() function. See patch for details.

Files

a.patch (1.04 KB) a.patch Jaroslav Kysela, 2012-12-12 15:25

History

#1

Updated by Adam Sutton about 12 years ago

  • Status changed from New to Accepted
  • Assignee set to Adam Sutton
  • Affected Versions 3.2, 3.3 added

Agreed, but I think the problem is more general than this.

I think we should probably avoid using strtok() anywhere that requires a second call, else we need to carefully check all such instances to ensure they are only called from a single thread.

Adam

#2

Updated by Adam Sutton about 12 years ago

Thanks for the patch, I did the change myself in the end as I decided to do a complete (except one startup use) replacement of strtok() to avoid potential re-entrance/race issues.

Need to decide whether to backport to 3.2, probably yes!

Adam

#3

Updated by Adam Sutton about 12 years ago

  • Status changed from Accepted to Resolved

Should now be fixed on master, needs back porting.

Adam

#4

Updated by Adam Sutton about 12 years ago

  • Target version set to 3.2
#5

Updated by Adam Sutton about 12 years ago

  • Status changed from Resolved to Fixed
  • % Done changed from 0 to 100

Applied in changeset commit:165e3d4cb08f21ed2501b4b06e6d12bd3f4c9f26.

Also available in: Atom PDF