Tvheadend

Because source is not some Capture card with send RAW data only Encoding is not enough ;)
Transcoding is other thing ;)
source > decoding > processing > encoding > output ~ transcoding

Alin Gherghescu wrote:

4. Decoder HW + Encoder SW --> not working (with VAAPI)

the fix is:
replace function _video_filters_get_filters() from src/transcoding/transcode/video.c with function below.

static int
_video_filters_get_filters(TVHContext *self, AVDictionary **opts, char **filters)
{
    char download[48];
    char deint[8];
    char hw_deint[64];
    char scale[24];
    char hw_scale[64];
    char upload[48];
    int ihw = _video_filters_hw_pix_fmt(self->iavctx->pix_fmt);
    int ohw = _video_filters_hw_pix_fmt(self->oavctx->pix_fmt);
    int filter_scale = (self->iavctx->height != self->oavctx->height);
    int filter_deint = 0, filter_download = 0, filter_upload = 0;

    if (tvh_context_get_int_opt(opts, "tvh_filter_deint", &filter_deint)) {
        return -1;
    }
    filter_download = (ihw && (!ohw || filter_scale || filter_deint)) ? 1 : 0;
    filter_upload = ((filter_download || !ihw) && ohw) ? 1 : 0;

    memset(deint, 0, sizeof(deint));
    memset(hw_deint, 0, sizeof(hw_deint));
#if ENABLE_HWACCELS
    if (filter_deint) {
        // when hwaccel is enabled we have two optios:
        if (ihw) {
            // hw deint
            hwaccels_get_deint_filter(self->iavctx, hw_deint, sizeof(hw_deint));
        }
        else {
            // sw deint
            if (str_snprintf(deint, sizeof(deint), "yadif")) {
                return -1;
            }
        }
    }
#else
    if (filter_deint) {
        if (str_snprintf(deint, sizeof(deint), "yadif")) {
            return -1;
        }
    }
#endif

    memset(scale, 0, sizeof(scale));
    memset(hw_scale, 0, sizeof(hw_scale));
#if ENABLE_HWACCELS
    if (filter_scale) {
        // when hwaccel is enabled we have two optios:
        if (ihw) {
            // hw scale
            hwaccels_get_scale_filter(self->iavctx, self->oavctx, hw_scale, sizeof(hw_scale));
        }
        else {
            // sw scale
            if (str_snprintf(scale, sizeof(scale), "scale=w=-2:h=%d",
                         self->oavctx->height)) {
                return -1;
            }
        }
    }
#else
    if (filter_scale) {
        if (str_snprintf(scale, sizeof(scale), "scale=w=-2:h=%d",
                         self->oavctx->height)) {
            return -1;
        }
    }
#endif

#if ENABLE_HWACCELS
    if (hw_deint[0] == '\0' && deint[0] == '\0' && hw_scale[0] == '\0' && scale[0] == '\0') {
        filter_download = filter_upload = 0;
    }
#else
    if (deint[0] == '\0' && scale[0] == '\0') {
        filter_download = filter_upload = 0;
    }
#endif

    memset(download, 0, sizeof(download));
    if (filter_download &&
        str_snprintf(download, sizeof(download), "hwdownload,format=pix_fmts=%s",
                     av_get_pix_fmt_name(self->iavctx->sw_pix_fmt))) {
        return -1;
    }

    memset(upload, 0, sizeof(upload));
    if (filter_upload &&
        str_snprintf(upload, sizeof(upload), "format=pix_fmts=%s|%s,hwupload",
                     av_get_pix_fmt_name(self->oavctx->sw_pix_fmt),
                     av_get_pix_fmt_name(self->oavctx->pix_fmt))) {
        return -1;
    }

    if (!(*filters = str_join(",", hw_deint, hw_scale, download, deint, scale, upload, NULL))) {
        return -1;
    }

    return 0;
}

saen acro wrote:

Because source is not some Capture card with send RAW data only Encoding is not enough ;)
Transcoding is other thing ;)
source > decoding > processing > encoding > output ~ transcoding

I don't understand your comment ... let me add a cartoon (to clarify).

Decoder and processing is combined in section
aka only for decoding is check box for HW decoding.
Resize and Deinterlace is processing.

It will be very good if there appear also "denoise" and "sharpen"

https://www.intel.com/content/www/us/en/developer/articles/technical/media-framework-upstream-patches-2022-q3.html

Alin Gherghescu wrote:

Alin Gherghescu wrote:

4. Decoder HW + Encoder SW --> not working (with VAAPI)

the fix is:
replace function _video_filters_get_filters() from src/transcoding/transcode/video.c with function below.

[...]

Its possible in this code to add hw encoding???
We have some progress! Now i have picture but cpu is verry slow and do not encode properly! With checkbox, on or off I dont have any difeerence in encoding speed!

Kiril St. wrote:

Alin Gherghescu wrote:

Alin Gherghescu wrote:

4. Decoder HW + Encoder SW --> not working (with VAAPI)

the fix is:
replace function _video_filters_get_filters() from src/transcoding/transcode/video.c with function below.

[...]

Its possible in this code to add hw encoding???
We have some progress! Now i have picture but cpu is verry slow and do not encode properly! With checkbox, on or off I dont have any difeerence in encoding speed!

Monitor your GPU with this
https://github.com/Syllo/nvtop
For intel GPU need kernel 5.19+ to see all telemetry, but and basic will be enough.

Its good idea for feature to have some GPU capability checker when TVH start
something similar to nv-video-info
with can post in log what can do GPU HW transcoding.

Kiril St. wrote:

Its possible in this code to add hw encoding???
We have some progress! Now i have picture but cpu is verry slow and do not encode properly! With checkbox, on or off I dont have any difeerence in encoding speed!

Can you provide: CPU (eventually what motherboard or PC you use), OS and what HW encoder you try to use (Nvidia, Intel AMD / nvec or vaapi). Also resolution IN, resolution OUT, channel is encoded by provider in ... (MPEG2, H264 ...) and you are trying to transcode that in .... (H264, VP8 ...). I hope you build TVH from Master (and not use some prebuild binary ... ) - please confirm how you installed tvh.

saen acro wrote:

It will be very good if there appear also "denoise" and "sharpen"

looking at:
https://ffmpeg.org/doxygen/4.0/index.html

I got to:
https://ffmpeg.org/doxygen/4.0/dir_07c4be17d34b4a7a38dbd1b8cb6b1e6c.html

But If you search for "VAAPI" you will see that "denoise" and "sharpen" are not available as filter for VAAPI (HW filter) ... there are other SW filters ... but I don't think is practical to try to use those in real time.

Even latest ffmpeg git doesn't seem to have:
https://github.com/FFmpeg/FFmpeg/tree/master/libavfilter
denoise_vaapi or sharpen_vaapi available.
Do you think I am missing something?

I found half of your request (denoise) ... but bad news: is only available in qsv (not in vaapi)
https://github.com/FFmpeg/FFmpeg/blob/master/libavfilter/vf_vpp_qsv.c
So ... there is a long path to that.

You search them on wrong place ;)
https://github.com/intel/cartwheel-ffmpeg/tree/4.4/patches

saen acro wrote:

You search them on wrong place ;)
https://github.com/intel/cartwheel-ffmpeg/tree/4.4/patches

Correct me if I am wrong: those are not patches applied to ffmpeg 4 that are already in ffmpeg 5?
I checked all patches but could not find anything related to "denoise" and "sharpen".
https://github.com/intel/cartwheel-ffmpeg/blob/4.4/patches/0074-avutils-hwcontext_qsv-set-the-source-device-in-qsv_d.patch
this one has some example filter with "unsharp_opencl" ... but this I think is inverse of "sharpen"

my comment previous post are from ffmpeg master ... long path to intercept .

ffmpeg compiled couple of months a go is confirming this:

Alin Gherghescu wrote:

saen acro wrote:

You search them on wrong place ;)
https://github.com/intel/cartwheel-ffmpeg/tree/4.4/patches

Correct me if I am wrong: those are not patches applied to ffmpeg 4 that are already in ffmpeg 5?
I checked all patches but could not find anything related to "denoise" and "sharpen".
https://github.com/intel/cartwheel-ffmpeg/blob/4.4/patches/0074-avutils-hwcontext_qsv-set-the-source-device-in-qsv_d.patch
this one has some example filter with "unsharp_opencl" ... but this I think is inverse of "sharpen"

my comment previous post are from ffmpeg master ... long path to intercept .

With version of FFMPEG is used in TVH in the moment 4.0 or 5.0?
Change branch on top and will have them for 5.0 or 5.1 or master for current.

saen acro wrote:

Alin Gherghescu wrote:

saen acro wrote:

With version of FFMPEG is used in TVH in the moment 4.0 or 5.0?

bad news: we are on 4.4.

or maybe you are referring to sharpness (not 'sharpen').

Alin Gherghescu wrote:

or maybe you are referring to sharpness (not 'sharpen').

synonym of the same word

intel page from upper post

Tested Features
Decode: AVC/H264, HEVC/H265 (8/10/12bit), AV1 (8/10bit), VP9 (8, 10, 12bit), VP8, JPEG/MJPEG, MPEG2, VC1
Encode: AV1 (ffmpeg-vaapi, ffmpeg-qsv and gst-msdk supported but not gst-vaapi), AVC/H264, HEVC/H265 (8/10bit), VP9 (8/10bit), VP8, JPEG/MJPEG, MPEG2
VPP : brightness/contrast/saturation/hue, csc, deinterlace, denoise, scale, sharpen, mirroring, rotation, transpose

Sharpening is needed for upscaling

@ sean arco
Please confirm this is what you had in mind for: denoise_vaapi and sharpness_vaapi
https://github.com/uknunknown/tvheadend
I didn't used those filters so I don't know what to expect (as video enhancement)... can you verify and confirm before I submit the PR?
Thank you.

On Opera browser there is option "video enhancer" aka "Lucid mode"
https://www.opera.com/features/lucid-mode

this is result of both, except color booster and pseudo HDR

````

Is anyone can find conflicts in code with make update to FFMpeg to 4.3.3 impossible
https://github.com/tvheadend/tvheadend/blob/master/Makefile.ffmpeg#L111
https://github.com/FFmpeg/FFmpeg/compare/n4.4.1...n4.4.3 comparsion