Project

General

Profile

Bug #6310

tvhmeta: All fetch_and_persist_artwork function calls fail

Added by James Bevan about 1 year ago. Updated about 1 year ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
General
Target version:
-
Start date:
2023-10-14
Due date:
% Done:

0%

Estimated time:
Found in version:
4.3-2156~g51adc0404
Affected Versions:

Description

A fair sized rework of the tvhmeta script was merged in https://github.com/tvheadend/tvheadend/commit/18effa8ad93e901f3cdaa534123d910f14453d1f.

At line 245, in the fetch_and_persist_artwork function call, the default value of 'okay' is set to False, and no subsequent instruction sets it to True before its condition is checked.

It looks like the default value is meant to be True, as setting it this way allows the rest of the function to operate correctly, unless of course one of the error conditions is met.

Opening this issue so I can follow up with a PR.

History

#1

Updated by James Bevan about 1 year ago

James Bevan wrote:

A fair sized rework of the tvhmeta script was merged in https://github.com/tvheadend/tvheadend/commit/18effa8ad93e901f3cdaa534123d910f14453d1f.

At line 245, in the fetch_and_persist_artwork function call, the default value of 'okay' is set to False, and no subsequent instruction sets it to True before its condition is checked.

It looks like the default value is meant to be True, as setting it this way allows the rest of the function to operate correctly, unless of course one of the error conditions is met.

Opening this issue so I can follow up with a PR.

This fix has been merged now.

#2

Updated by Flole Systems about 1 year ago

  • Status changed from New to Fixed

Also available in: Atom PDF