Bug #6310
tvhmeta: All fetch_and_persist_artwork function calls fail
0%
Description
A fair sized rework of the tvhmeta script was merged in https://github.com/tvheadend/tvheadend/commit/18effa8ad93e901f3cdaa534123d910f14453d1f.
At line 245, in the fetch_and_persist_artwork function call, the default value of 'okay' is set to False, and no subsequent instruction sets it to True before its condition is checked.
It looks like the default value is meant to be True, as setting it this way allows the rest of the function to operate correctly, unless of course one of the error conditions is met.
Opening this issue so I can follow up with a PR.
History
Updated by James Bevan about 1 year ago
James Bevan wrote:
A fair sized rework of the tvhmeta script was merged in https://github.com/tvheadend/tvheadend/commit/18effa8ad93e901f3cdaa534123d910f14453d1f.
At line 245, in the fetch_and_persist_artwork function call, the default value of 'okay' is set to False, and no subsequent instruction sets it to True before its condition is checked.
It looks like the default value is meant to be True, as setting it this way allows the rest of the function to operate correctly, unless of course one of the error conditions is met.
Opening this issue so I can follow up with a PR.
This fix has been merged now.