Bug #6279
Commit dbf9733 breaks compilation on non GLIBC systems
Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
General
Target version:
-
Start date:
2023-06-23
Due date:
% Done:
0%
Estimated time:
Found in version:
dbf9733
Affected Versions:
Description
getcwd() was changed to get_current_dir_name() (a GNU extension) which breaks compilation on non GLIBC systems. The attached file restores the previous behavior.
Files
History
Updated by Flole Systems over 1 year ago
Please submit a PR, patches submitted here can't be accepted.
Updated by Oliver Schinagl over 1 year ago
I think John's patch got merged, so we can close this issue.
But I am curious what system john was compiling on to trigger this, as both musl and glibc support this extension.
Short of an answer, I really question whether we should try to support 'all non-glibc' variants. It's a maintenance burden in the end, and requiring glibc (to an extend, e.g. musl compatibility) seems not unreasonable?