Tvheadend

Looks like nvenc is just doing encoding and not decoding, I observed this aswell a while ago. I would like to get this changed aswell but unfortunately I haven't really looked into transcoding and for me this is not really causing problems at the moment unless I try to use it for a h265 encoded 4k channel.

Flole Systems wrote:

Looks like nvenc is just doing encoding and not decoding, I observed this aswell a while ago. I would like to get this changed aswell but unfortunately I haven't really looked into transcoding and for me this is not really causing problems at the moment unless I try to use it for a h265 encoded 4k channel.

For decoding you need nvdec. nvenc is only for encoding.

Yes I'm aware of that, but I thought that selecting the nvenc encoder automatically selects the nvdec decoder, which is not the case. I've looked at the ffmpeg makefile that's part of tvheadend and it doesn't contain the required flags to compile for nvdec. I guess that's the first thing we need to fix, and then we can start to look at how to tell tvheadend to actually use it.

Hallo,
As far as I had come, it seems only encoding makes.
The decoding is not addressed at all, or is not in the compile of ffmpeg.
At vaapi I also saw some parts in the source, but not at nvidia Decoding.
Who can take care of this? Because I can unfortunately no programing C.

maybe even the current form is wrong,
because with a SPAWN profile it looks right ...
ffmpeg [...] -hwaccel nvdec [...] -i pipe:0 -c: v hevc_nvenc [...] -f mpegts pipe:1

BR
Ronnny

I've done some investigation regarding this topic and came up with this patch to enable some nvidia related hardware acceleration functions (nvdec and cuvid) in the ffmpeg build. However, this is not enough, we probably need a copy of src/transcoding/transcode/hwaccels/vaapi.c and a few additions in src/transcoding/transcode/hwaccels/hwaccels.c for nvdec/cuvid.

--- Makefile.ffmpeg     2019-03-13 17:49:41.330644268 +0100
+++ Makefile.ffmpeg     2019-11-25 23:47:07.594583854 +0100
@@ -558,8 +558,10 @@

 ifeq (yes,$(CONFIG_NVENC))

-EXTLIBS  += nvenc
+EXTLIBS  += nvenc nvdec cuvid
 ENCODERS += h264_nvenc hevc_nvenc
+DECODERS += h264_nvdec hevc_nvdec vp8_nvdec mjpeg_nvdec h264_cuvid hevc_cuvid vp8_cuvid mjpeg_cuvid mpeg1_cuvid mpeg2_cuvid mpeg4_cuvid
+HWACCELS += h264_nvdec hevc_nvdec vp8_nvdec mjpeg_nvdec h264_cuvid hevc_cuvid vp8_cuvid mjpeg_cuvid mpeg1_cuvid mpeg2_cuvid mpeg4_cuvid

 $(LIB_ROOT)/$(FFNVCODEC)/.tvh_download:
        $(call DOWNLOAD,$(FFNVCODEC_URL),$(LIB_ROOT)/$(FFNVCODEC_TB),$(FFNVCODEC_SHA1))

--- configure   2019-11-26 01:47:33.113533125 +0100
+++ configure       2019-11-26 01:47:27.133390956 +0100
@@ -600,6 +600,7 @@
     #check_cc_header nvEncodeAPI || \
     #  die "NVENC library (https://developer.nvidia.com/nvidia-video-codec-sdk) not found" 
     enable nvenc
+    enable hwaccels
   else
     disable nvenc
   fi

A good description is here: https://devblogs.nvidia.com/nvidia-ffmpeg-transcoding-guide/

The description does not cover the c implementation though. Still for someone who doesn't know how this works it could be helpful, but it's not helping with the implementation unfortunately.

Hallo,
so i have checked this code, and i have a little bit change this ;-)
now ready for usage, but "NVDEC" is not working in TVHeadend only all ffmpeg HWACCELS option is now ready for TVHaedend.
And you must install NVIDIA CUDA for ext Libs. (see in coments)

Now you can see is the HWACCELS section filled.

BR
Ronny

index 8768de8b1..e6792e9c2 100644
--- a/Makefile.ffmpeg
+++ b/Makefile.ffmpeg
@@ -164,10 +164,12 @@ endif
 ECFLAGS   := -I$(EPREFIX)/include $(CFLAGS_PI)
 ELIBS     := -L$(EPREFIX)/lib -ldl

+
 CONFIGURE := FFMPEG_PREFIX=$(EPREFIX) \
              PKG_CONFIG=$(ROOTDIR)/support/pkg-config.ffmpeg \
              ./configure --prefix=/ffmpeg --enable-static --disable-shared
 CONFIGURE_PI := CC="$(COMPILER) $(CFLAGS_PI)" $(CONFIGURE)
+CONFIGURE_FFMPEG := $(CONFIGURE)

 # ##############################################################################
 # NASM
@@ -558,8 +560,14 @@ endif

 ifeq (yes,$(CONFIG_NVENC))

-EXTLIBS  += nvenc
-ENCODERS += h264_nvenc hevc_nvenc
+## YOU MUST INSTALL CUDA from NVIDIA for "libnpp" 
+EXTLIBS   += nvenc cuvid nonfree libnpp
+ENCODERS  += h264_nvenc hevc_nvenc
+HWACCELS  += h264_nvdec hevc_nvdec vp8_nvdec mjpeg_nvdec mpeg1_nvdec mpeg2_nvdec mpeg4_nvdec
+ECFLAGS   += -I/usr/local/cuda/include
+
+## NVIDIA LIB for "libnpp" 
+CONFIGURE_FFMPEG += --extra-ldflags=-L/usr/local/cuda/lib64

 $(LIB_ROOT)/$(FFNVCODEC)/.tvh_download:
        $(call DOWNLOAD,$(FFNVCODEC_URL),$(LIB_ROOT)/$(FFNVCODEC_TB),$(FFNVCODEC_SHA1))
@@ -675,7 +683,7 @@ $(LIB_ROOT)/$(FFMPEG)/.tvh_build: \
                $(LIB_ROOT)/$(LIBOPUS)/.tvh_build \
                $(LIB_ROOT)/$(FFNVCODEC)/.tvh_build \
                $(LIB_ROOT)/$(FFMPEG)/.tvh_download
-       cd $(LIB_ROOT)/$(FFMPEG) && $(CONFIGURE) \
+       cd $(LIB_ROOT)/$(FFMPEG) && $(CONFIGURE_FFMPEG) \
                --disable-all \
                --enable-gpl \
                --enable-nonfree \
diff --git a/configure b/configure
index e76760479..f07e7a73e 100755
--- a/configure
+++ b/configure
@@ -600,6 +600,7 @@ if enabled ffmpeg_static; then
     #check_cc_header nvEncodeAPI || \
     #  die "NVENC library (https://developer.nvidia.com/nvidia-video-codec-sdk) not found" 
     enable nvenc
+    enable hwaccels
   else
     disable nvenc
   fi

BEFORE (ORIGINAL)

cd /usr/src/tvheadend/build.linux/ffmpeg/ffmpeg-4.1.1 && FFMPEG_PREFIX=/usr/src/tvheadend/build.linux/ffmpeg/build/ffmpeg PKG_CONFIG=/usr/src/tvheadend/support/pkg-config.ffmpeg ./configure --prefix=/ffmpeg --enable-static --disable-shared \
        --disable-all \
        --enable-gpl \
        --enable-nonfree \
        --extra-cflags="-I/usr/src/tvheadend/build.linux/ffmpeg/build/ffmpeg/include -fPIE" \
        --extra-libs="-L/usr/src/tvheadend/build.linux/ffmpeg/build/ffmpeg/lib -ldl" \
        --pkg-config="/usr/src/tvheadend/support/pkg-config.ffmpeg" \
        --enable-openssl \
        --enable-avutil --enable-avcodec --enable-avformat --enable-swscale --enable-avresample --enable-swresample --enable-avfilter \
        --enable-libx264 --enable-libx265 --enable-libvpx --enable-libtheora --enable-libvorbis --enable-libopus --enable-nvenc --enable-nonfree \
        --enable-protocol=file --enable-protocol=http --enable-protocol=https --enable-protocol=hls --enable-protocol=mmsh --enable-protocol=mmst --enable-protocol=rtmp --enable-protocol=rtmpe --enable-protocol=rtmps --enable-protocol=rtmpt --enable-protocol=rtmpte --enable-protocol=rtmpts --enable-protocol=ffrtmpcrypt --enable-protocol=ffrtmphttp --enable-protocol=rtp --enable-protocol=srtp --enable-protocol=tcp --enable-protocol=udp --enable-protocol=udplite --enable-protocol=unix --enable-protocol=crypto \
        --enable-decoder=mpeg2video --enable-decoder=mp2 --enable-decoder=aac --enable-decoder=vorbis --enable-decoder=ac3 --enable-decoder=eac3 --enable-decoder=aac_latm --enable-decoder=opus --enable-decoder=h264 --enable-decoder=hevc --enable-decoder=theora --enable-decoder=flac --enable-decoder=libvorbis \
        --enable-encoder=mpeg2video --enable-encoder=mp2 --enable-encoder=aac --enable-encoder=vorbis --enable-encoder=flac --enable-encoder=libx264 --enable-encoder=libx265 --enable-encoder=libvpx_vp8 --enable-encoder=libvpx_vp9 --enable-encoder=libtheora --enable-encoder=libvorbis --enable-encoder=libopus --enable-encoder=h264_nvenc --enable-encoder=hevc_nvenc \
        --enable-demuxer=mpegts --enable-demuxer=matroska --enable-demuxer=hls --enable-demuxer=flv --enable-demuxer=live_flv \
        --enable-muxer=mpegts --enable-muxer=matroska --enable-muxer=mp4 --enable-muxer=ogg \
        --enable-bsf=h264_mp4toannexb --enable-bsf=hevc_mp4toannexb \
        --enable-filter=yadif --enable-filter=format --enable-filter=hwupload --enable-filter=hwdownload --enable-filter=scale --enable-filter=null --enable-filter=aresample --enable-filter=anull \
         \
                --disable-programs \
                --disable-doc \
                --disable-htmlpages \
                --disable-manpages \
                --disable-podpages \
                --disable-txtpages

External libraries:
iconv                     libtheora                 libvorbis                 libvpx                    libx264                   libx265                   libxcb                    openssl                   zlib
libopus

External libraries providing hardware acceleration:
cuda                      cuvid                     ffnvcodec                 nvdec                     nvenc                     v4l2_m2m                  vaapi

Libraries:
avcodec                   avfilter                  avformat                  avresample                avutil                    swresample                swscale

Programs:

Enabled decoders:
aac                       ac3                       flac                      hevc                      mp2                       opus                      theora                    vorbis                    vp3
aac_latm                  eac3                      h264                      libvorbis                 mpeg2video

Enabled encoders:
aac                       h264_nvenc                libopus                   libvorbis                 libvpx_vp9                libx265                   mp2                       mpeg2video                vorbis
flac                      hevc_nvenc                libtheora                 libvpx_vp8                libx264

Enabled hwaccels:

Enabled parsers:
aac_latm                  ac3

Enabled demuxers:
flv                       hls                       live_flv                  matroska                  mpegts

Enabled muxers:
adts                      latm                      matroska                  mov                       mp4                       mpegts                    ogg

Enabled protocols:
crypto                    file                      https                     rtmp                      rtmpt                     rtmpts                    srtp                      tls                       udplite
ffrtmpcrypt               hls                       mmsh                      rtmpe                     rtmpte                    rtp                       tcp                       udp                       unix
ffrtmphttp                http                      mmst                      rtmps

Enabled filters:
anull                     aresample                 format                    hwdownload                hwupload                  null                      scale                     yadif

Enabled bsfs:
h264_mp4toannexb          hevc_mp4toannexb          null

Enabled indevs:

Enabled outdevs:

License: nonfree and unredistributable

WARNING: Building with deprecated library libavresample

NOW (with this patch)

cd /usr/src/tvheadend/build.linux/ffmpeg/ffmpeg-4.1.1 && FFMPEG_PREFIX=/usr/src/tvheadend/build.linux/ffmpeg/build/ffmpeg PKG_CONFIG=/usr/src/tvheadend/support/pkg-config.ffmpeg ./configure --prefix=/ffmpeg --enable-static --disable-shared --extra-ldflags=-L/usr/local/cuda/lib64 \
        --disable-all \
        --enable-gpl \
        --enable-nonfree \
        --extra-cflags="-I/usr/src/tvheadend/build.linux/ffmpeg/build/ffmpeg/include -fPIE -I/usr/local/cuda/include" \
        --extra-libs="-L/usr/src/tvheadend/build.linux/ffmpeg/build/ffmpeg/lib -ldl" \
        --pkg-config="/usr/src/tvheadend/support/pkg-config.ffmpeg" \
        --enable-openssl \
        --enable-avutil --enable-avcodec --enable-avformat --enable-swscale --enable-avresample --enable-swresample --enable-avfilter \
        --enable-libx264 --enable-libx265 --enable-libvpx --enable-libtheora --enable-libvorbis --enable-libopus --enable-nvenc --enable-cuvid --enable-nonfree --enable-libnpp --enable-nonfree \
        --enable-protocol=file --enable-protocol=http --enable-protocol=https --enable-protocol=hls --enable-protocol=mmsh --enable-protocol=mmst --enable-protocol=rtmp --enable-protocol=rtmpe --enable-protocol=rtmps --enable-protocol=rtmpt --enable-protocol=rtmpte --enable-protocol=rtmpts --enable-protocol=ffrtmpcrypt --enable-protocol=ffrtmphttp --enable-protocol=rtp --enable-protocol=srtp --enable-protocol=tcp --enable-protocol=udp --enable-protocol=udplite --enable-protocol=unix --enable-protocol=crypto \
        --enable-decoder=mpeg2video --enable-decoder=mp2 --enable-decoder=aac --enable-decoder=vorbis --enable-decoder=ac3 --enable-decoder=eac3 --enable-decoder=aac_latm --enable-decoder=opus --enable-decoder=h264 --enable-decoder=hevc --enable-decoder=theora --enable-decoder=flac --enable-decoder=libvorbis \
        --enable-encoder=mpeg2video --enable-encoder=mp2 --enable-encoder=aac --enable-encoder=vorbis --enable-encoder=flac --enable-encoder=libx264 --enable-encoder=libx265 --enable-encoder=libvpx_vp8 --enable-encoder=libvpx_vp9 --enable-encoder=libtheora --enable-encoder=libvorbis --enable-encoder=libopus --enable-encoder=h264_nvenc --enable-encoder=hevc_nvenc \
        --enable-demuxer=mpegts --enable-demuxer=matroska --enable-demuxer=hls --enable-demuxer=flv --enable-demuxer=live_flv \
        --enable-muxer=mpegts --enable-muxer=matroska --enable-muxer=mp4 --enable-muxer=ogg \
        --enable-bsf=h264_mp4toannexb --enable-bsf=hevc_mp4toannexb \
        --enable-filter=yadif --enable-filter=format --enable-filter=hwupload --enable-filter=hwdownload --enable-filter=scale --enable-filter=null --enable-filter=aresample --enable-filter=anull \
        --enable-hwaccel=h264_nvdec --enable-hwaccel=hevc_nvdec --enable-hwaccel=vp8_nvdec --enable-hwaccel=mjpeg_nvdec --enable-hwaccel=mpeg1_nvdec --enable-hwaccel=mpeg2_nvdec --enable-hwaccel=mpeg4_nvdec \
                --disable-programs \
                --disable-doc \
                --disable-htmlpages \
                --disable-manpages \
                --disable-podpages \
                --disable-txtpages

External libraries:
iconv                     libtheora                 libvorbis                 libvpx                    libx264                   libx265                   libxcb                    openssl                   zlib
libopus

External libraries providing hardware acceleration:
cuda                      cuvid                     ffnvcodec                 libnpp                    nvdec                     nvenc                     v4l2_m2m                  vaapi

Libraries:
avcodec                   avfilter                  avformat                  avresample                avutil                    swresample                swscale

Programs:

Enabled decoders:
aac                       eac3                      h263                      hevc                      mjpeg                     mpeg1video                mpeg4                     theora                    vp3
aac_latm                  flac                      h264                      libvorbis                 mp2                       mpeg2video                opus                      vorbis                    vp8
ac3

Enabled encoders:
aac                       h264_nvenc                libopus                   libvorbis                 libvpx_vp9                libx265                   mp2                       mpeg2video                vorbis
flac                      hevc_nvenc                libtheora                 libvpx_vp8                libx264

Enabled hwaccels:
h264_nvdec                hevc_nvdec                mjpeg_nvdec               mpeg1_nvdec               mpeg2_nvdec               mpeg4_nvdec               vp8_nvdec

Enabled parsers:
aac_latm                  ac3                       h263                      mpeg4video

Enabled demuxers:
flv                       hls                       live_flv                  matroska                  mpegts

Enabled muxers:
adts                      latm                      matroska                  mov                       mp4                       mpegts                    ogg

Enabled protocols:
crypto                    file                      https                     rtmp                      rtmpt                     rtmpts                    srtp                      tls                       udplite
ffrtmpcrypt               hls                       mmsh                      rtmpe                     rtmpte                    rtp                       tcp                       udp                       unix
ffrtmphttp                http                      mmst                      rtmps

Enabled filters:
anull                     aresample                 format                    hwdownload                hwupload                  null                      scale                     yadif

Enabled bsfs:
h264_mp4toannexb          hevc_mp4toannexb          null

Enabled indevs:

Enabled outdevs:

License: nonfree and unredistributable

WARNING: Building with deprecated library libavresample

Ronny M. wrote:

And you must install NVIDIA CUDA for ext Libs. (see in coments)

Most any transcoding software recommend installing of nVidia cuda-toolkit package with, include video drivers also,
Nvenc is part of CUDA

If I see that correctly most of the code needed is already part of ffmpegs libavcodec/nvdec.c file, all that's left is integrating this file to tvheadend. So if someone wants to work on this, this might be a good starting point.

Flole Systems wrote:

If I see that correctly most of the code needed is already part of ffmpegs libavcodec/nvdec.c file, all that's left is integrating this file to tvheadend. So if someone wants to work on this, this might be a good starting point.

not exactly need some of https://github.com/FFmpeg/nv-codec-headers

There's no point in including the encoders if they are never used. The patch above also includes them.

Flole Systems wrote:

There's no point in including the encoders if they are never used. The patch above also includes them.

Hi Flole,
nice now it is at least not a bug anymore, but a feature.... ;-)

That's right and exactly my problem, I understand everything else that is still necessary here, but unfortunately I don't have programming experience here, but if I can help you / or others with testing and reports, I'm happy to be on board!

because knowing always only harms those who don't have it. ;-)

Interestingly enough I am having issues transcoding using nvenc for some reason, so I need to figure out why that isn't working for me at the moment Otherwise even if I wanted and had time I couldn't start working on that. Seems like I'm the only one with that issue though for some reason....

Flole Systems wrote:

Interestingly enough I am having issues transcoding using nvenc for some reason, so I need to figure out why that isn't working for me at the moment Otherwise even if I wanted and had time I couldn't start working on that. Seems like I'm the only one with that issue though for some reason....

Flole Systems
Please discribe your Problem...
with NVENC have there are always many times many problems....

Come you from Germany?
Then we can in a simple chat or call via Telefone initiate ;-) and all the Probelms inspect and to discuss..!?!?

and not one question or coment and 20 Days Later a Answer....

Previous tests look good so far, but the CPU load is still high despite the GPU now doing the decoding.
My guess is that this is due to the missing HW upload / download of the filter.