Project

General

Profile

Bug #5441

Channel merging logic appears to favour merging into the highest number channel.

Added by J Blanc almost 6 years ago. Updated almost 6 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
Service Mapping
Target version:
-
Start date:
2018-12-16
Due date:
% Done:

100%

Estimated time:
Found in version:
4.3
Affected Versions:

Description

This is a usability bug.

Currently channel merging operations seem to favour merging into, and thus retaining the highest channel number. (I think it isn't intentional, just an implicit result of the order operations are taken.) This isn't ideal, since for example, on BSkyB lineups it will result in "Channel Four" at channel number 104, being merged into a duplicate at channel number 974 and retaining this higher number. And at first glance it appears that "Channel Four" has disappeared from the lineup until you look up into the far higher numbers.

Can there be some logic added to prefer a merge into the lowest number, which is more likely to retain the intended EPG channel ordering.

History

#1

Updated by J Blanc almost 6 years ago

After looking through the source, the bug is in channels.c

At the moment channel_get_number iterates through possible sources of a channel number, with a break when it finds one. Because of the order that bouquet entries are stored in, this means that the highest possible number for a channel is always returned.

Can this be fixed to return the lowest number from all linked services, rather than the first service present?

#2

Updated by Andreas Fornberg almost 6 years ago

I agree i think that would be better or atleast make that as an option.

#3

Updated by Jaroslav Kysela almost 6 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset commit:tvheadend|419b0a143c439b50f7d2d979945f5e8d2f6769d1.

Also available in: Atom PDF