Bug #5400
Reduce DESCRAMBLER_MAX_KEYS from 64 to 8.
Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
Descrambling
Target version:
-
Start date:
2018-12-06
Due date:
% Done:
100%
Estimated time:
Found in version:
4.3
Affected Versions:
Description
from oscam-emu:
#define PVU_CW_VID 0 // VIDeo #define PVU_CW_HSD 1 // High Speed Data #define PVU_CW_A1 2 // Audio 1 #define PVU_CW_A2 3 // Audio 2 #define PVU_CW_A3 4 // Audio 3 #define PVU_CW_A4 5 // Audio 4 #define PVU_CW_UTL 6 // UTiLity #define PVU_CW_VBI 7 // Vertical Blanking Interval
So a max of 8 is plenty. (I have never seen more than 5 used.)
I generally don't care about oversized arrays, but each descrambler using multipid calls tvhcsa_init for each "possible" pid/key.
for (i = 0; i < DESCRAMBLER_MAX_KEYS; i++) { tk = &dr->dr_keys[i]; tk->key_index = 0xff; tk->key_interval = tk->key_initial_interval = ms2mono(interval); tvhcsa_init(&tk->key_csa); if (!multipid) break; }
pull request here: [[https://github.com/tvheadend/tvheadend/pull/1232]]
History
Updated by Joe User about 6 years ago
- Status changed from New to Fixed
- % Done changed from 0 to 100
Applied in changeset commit:tvheadend|ccf6c6ec7e5d34b1279a591794e421b63f3dc5ac.