Project

General

Profile

Bug #5192

MKV built-in muxer creates a file with an empty Codec private data in video track

Added by Alexey Suhinin about 6 years ago. Updated about 6 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
John Törnblom
Category:
Muxers
Target version:
-
Start date:
2018-09-06
Due date:
% Done:

100%

Estimated time:
Found in version:
trunk
Affected Versions:

Description

Patch fixes this problem:


--- a/src/plumbing/globalheaders.c
+++ b/src/plumbing/globalheaders.c
@ -101,7 +101,7 @
if(ssc->ssc_gh != NULL)
return;
.
- if(pkt->pkt_meta != NULL) {
+ if((pkt->pkt_meta != NULL) && ((SCT_ISVIDEO(pkt->pkt_type) && (pkt->v.pkt_frametype == PKT_I_FRAME)) || SCT_ISAUDIO(pkt->pkt_type))){
ssc->ssc_gh = pkt->pkt_meta;
pktbuf_ref_inc(ssc->ssc_gh);
return;

Files

stream.ts (33.7 MB) stream.ts Alexey Suhinin, 2018-09-07 11:13

History

#1

Updated by Jaroslav Kysela about 6 years ago

What's in the meta data when frame is not I-frame ?

#2

Updated by Alexey Suhinin about 6 years ago

Jaroslav Kysela wrote:

What's in the meta data when frame is not I-frame ?

Unknown 8 bytes, which do not contain the necessary information to muxer (an empty sequence is generated 0x63A2, 0x80)

#3

Updated by Jaroslav Kysela about 6 years ago

We should probably fix the meta data parser in src/parsers/parsers.c then. Please, attach the problematic input .TS stream - 30 seconds (grab the problematic service with the pass streaming profile - MPEG-TS format).

#4

Updated by Alexey Suhinin about 6 years ago

In attach

#5

Updated by Jaroslav Kysela about 6 years ago 

parser: h264 sps 43
parser: h264 pps 8
parser: h264 pps 8
parser: h264 pps 8
parser: h264 pps 8
parser: h264 pps 8
...
#6

Updated by Jaroslav Kysela about 6 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset commit:tvheadend|59b48c0f5c7b536270fe3e59fe42556abfb69cce.

Also available in: Atom PDF