Bug #5031
SAT>IP RTSP does not work on many media players....
0%
Description
Practically nowhere does the SAT>IP RTSP work, I get a Bad Request error -- 400. I little sorted this problem and made a patch.
Files
History
Updated by Jaroslav Kysela over 6 years ago
Send me list of commits in 4.3 you applied. I won't merge this - I cannot review the patch in this form.
Updated by Igor Mokrushin over 6 years ago
- File 002-satip_rtsp_fix.patch 002-satip_rtsp_fix.patch added
Jaroslav Kysela wrote:
Send me list of commits in 4.3 you applied. I won't merge this - I cannot review the patch in this form.
OK!
I taked next patches from branch 4.3:
1. https://github.com/tvheadend/tvheadend/commit/f0f9aa605ce4293b28430af3344b65ba14ec4e6e#diff-cac80cbafbb72ccbb46246ff8e5a8efd - It is not compulsory
2. https://github.com/tvheadend/tvheadend/commit/bafd78560c6fc2a0691c07708c32931bb1cac97b#diff-cac80cbafbb72ccbb46246ff8e5a8efd - rtsp_is_nat_active()
3. https://github.com/tvheadend/tvheadend/commit/3c5285d1c966312c78dad911262d7975a642d81b#diff-cac80cbafbb72ccbb46246ff8e5a8efd
4. https://github.com/tvheadend/tvheadend/commit/eea29c31e2b0f98c4bd8929af0f2dedfc425e25b#diff-cac80cbafbb72ccbb46246ff8e5a8efd
5. https://github.com/tvheadend/tvheadend/commit/06d3fdf5a496dfd847c4bf5fb8066bab41ee490f#diff-cac80cbafbb72ccbb46246ff8e5a8efd
6. https://github.com/tvheadend/tvheadend/commit/a7e2fed2c3ffd52423e0a96876ad31953063b16a#diff-cac80cbafbb72ccbb46246ff8e5a8efd
Of course, I adapted them for 4.2 and not all used. I made the necessary fixes for 4.3, which would also fix this problem.
Updated by Igor Mokrushin over 6 years ago
All these patches can not be used, except one - for VLC3 num.6. He partly solved my problems. My patch solves problems with other media players, the rtsp_parse_args() function tries to parse arguments from url, but at this time they are passed in the http header in a place with CSeq, that was not created servers if unless use hc_stream, so the player received a Bad Request...
Updated by Igor Mokrushin over 6 years ago
And one more thing, if you use several working media players on one computer, then after closing or stopping one of them, all the rest also stop playback. I figured out that this is answered by calling rtsp_clean(rs, 1) in rtsp_close_session(), if replace 1 on 0, then this problem disappears.
Updated by Jaroslav Kysela over 6 years ago
- Status changed from New to Rejected
I am afraid, I do not want to put those massive changes to 4.2 tree. Use or work with me on 4.3.