Project

General

Profile

Bug #4936

SAT>IP: UDP ports in UI typo

Added by Mono Polimorph over 6 years ago. Updated over 6 years ago.

Status:
Fixed
Priority:
Normal
Category:
SAT>IP
Target version:
-
Start date:
2018-02-13
Due date:
% Done:

100%

Estimated time:
Found in version:
last commit at 2018/02/12
Affected Versions:

Description

Hi Jaroslav,

Regarding this patch #4881, you missed one point: One RTSP connection can be doing more than one streaming. So you can have a list of mixed UDP and TCP ports. Futhermore, the current format is quite difficult to read.

So, I propose this simple patch:

diff --git a/src/webui/static/app/status.js b/src/webui/static/app/status.js
index 62e3b67..46cb476 100644
--- a/src/webui/static/app/status.js
+++ b/src/webui/static/app/status.js
@@ -658,11 +658,13 @@ tvheadend.status_conns = function(panel, index) {
                 renderer: function(v) {
                     if (!v) return '';
                     var o = '';
-                    if ('tcp' in v)
-                        o += _("TCP") + v.tcp.join(',');
+                    if ('tcp' in v) {
+                        if (o) o += ';';
+                        o += _("TCP:") + v.tcp.join(',');
+                    }
                     if ('udp' in v) {
                         if (o) o += ';';
-                        o += _("UDP") + v.udp.join(',');
+                        o += _("UDP:") + v.udp.join(',');
                     }
                     return o;
                 }

Please, commit it! ;)


Files

History

#1

Updated by Jaroslav Kysela over 6 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset commit:tvheadend|47d19a9f6701a2badffbd940de543726b82b9caf.

Also available in: Atom PDF