Project

General

Profile

Bug #4927

Extra warming up time is ignored if set over 240s

Added by dj bloc over 6 years ago. Updated over 6 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-02-08
Due date:
% Done:

100%

Estimated time:
Found in version:
4.2.5-14~g1665c35
Affected Versions:

Description

Using EPG accurate recording in the UK

To make sure recordings that start early (sports events finishing earlier than planned is typical) I set, under expert mode, in Configuration > Recording > Digital Video Recorder Profiles > Extra warming up time (seconds) to 600. This allows TVH to "monitor" the EPG accurate recording flag and commences HDD recording at the correct time.

However, if the value for this paramenter is set > 240s it never starts earlier than 4 mins (240 seconds).

I note this behaviour was also seen in the master git branch when I ran it a month ago.

History

#1

Updated by Jaroslav Kysela over 6 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset commit:tvheadend|c196a89f13ced5348a5ce93ec8e57460d6856360.

#2

Updated by dj bloc over 6 years ago

Jaroslav Kysela wrote:

Applied in changeset commit:tvheadend|c196a89f13ced5348a5ce93ec8e57460d6856360.

Thanks for the quick fix.

That fixes my issue but reviewing the code change it appears not to be user configurable to make it a larger value. If a minimum value is required should it not be set to MAX to set a minimum of 240s but let the user set larger?

#3

Updated by dj bloc over 6 years ago

above should state "MAX(<user parameter>, 240)"

#4

Updated by Jaroslav Kysela over 6 years ago

No, I'd like to restrict the value in the code to a boundary which makes sense. There is also 'Pre-recording padding' which increases the start time and it might make more sense for your purpose (because it works also without EITp/f). The warm time is mainly to compensate the delay between tuning and the stream reception for slow sources.

Also available in: Atom PDF