Project

General

Profile

Bug #4926

Previous change has broken the use of accurate recording / EPG running state for multipart / segmented programmes

Added by dj bloc over 6 years ago. Updated over 6 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-02-08
Due date:
% Done:

100%

Estimated time:
Found in version:
4.2.5-14~g1665c35
Affected Versions:

Description

Here in the UK we can reliably use EPG running state to accurate record the start and stop times when recording programmes. This has worked reliably for some time.

I've notice some recordings have finished short of the programmes and done some digging into what code changes may have affected this.

This seems to affects multi-part programmes or segmented programmes.

For example, this weekend on ITV2 channel the following film is being shown in segments between an entertainment show:

The Hangover Part 2 - 21:00 to 22:00 (Segment 1)
FYI Daily - 22:00 to 22:05
The Hangover Part 2 - 22:05 to 23:05 (Segment 2)

With the code committed here https://github.com/tvheadend/tvheadend/commit/409524e965b530debc96b0fd35ae97796a8ec00c I believe this causes accurate recording to stop working.

If I set both segments to record in TVheadend I see the following behaviour:

Let's assume the programme starts 2 mins later than scheduled...

TVH commences recording of Segment 1 at 21:02 using accurate recording.
At point of recording TVH would extend the stop time for Segment 1 from 22:00 to 23:05.
TVH commences recording of Segment 2 at 22:07.
TVH stops recording Segment 1 at 23:05 exactly ignoring the EPG running state stop mark
TVH stops recording Segment 2 at 23:07 using the EPG running state stop mark

This results in:
- One full recording (including FYI Daily) but stops prematurely
- One segment 2 recording that stops correctly.

Now previously I had an external program that would stitch together the two segments recordings to make one continuous playback. However that won't work anymore because segment 1 extends the time but not to the accurate end.

Can either of the following be actioned:
- Revert code commit so it records individual segments again
- (or even better) in this scenario segment 1 recording "monitors" the EPG running state of segment 2 ensuring an accurate ending.

Many thanks for the hard work


Files

multisegment-event-4926-extract.log.gz (552 KB) multisegment-event-4926-extract.log.gz multi-segment event trace dj bloc, 2018-02-11 01:41

History

#1

Updated by Jaroslav Kysela over 6 years ago

Show '--trace dvr' for one multi-segmented event and EITp/f.

#2

Updated by dj bloc over 6 years ago

Jaroslav Kysela wrote:

Show '--trace dvr' for one multi-segmented event and EITp/f.

Multi-segmented event is '22 Jump Street' on ITV2.

From looking at the attached the dvr entries are:

579220688c321509fa741dec80d22f29 (Segment 1)
b363caeb7a663825cced38b4b6facab2 (Segment 2)

In addition to the original issue it seems the EPG start mark is also being ignored.

#3

Updated by Jaroslav Kysela over 6 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset commit:tvheadend|c8d8639e9349916281eb7bb9dc204b8ba54adaf3.

#4

Updated by dj bloc over 6 years ago

Jaroslav Kysela wrote:

Applied in changeset commit:tvheadend|c8d8639e9349916281eb7bb9dc204b8ba54adaf3.

Many thanks. Please can this also be applied to the 4.2 branch.

#5

Updated by Jaroslav Kysela over 6 years ago

Done.

Also available in: Atom PDF