Tvheadend

This is from Kodi, trying to add a recording:

15:25:39.715 T:4078359120  NOTICE: VideoPlayer: finished waiting
15:25:52.379 T:4078359120   ERROR: AddOnLog: Tvheadend HTSP Client: pvr.hts - Command addDvrEntry failed: Could not add dvrEntry
15:25:52.379 T:4078359120   ERROR: PVR - AddTimer - addon 'Tvheadend:192.168.1.110:9982' returned an error: server error
15:25:52.379 T:4078359120   ERROR: PVR - AddTimer - cannot add timer to client '2146250725': server error

Hi, my TVH 4.3 (HTS Tvheadend 4.3-943~g9b85e7b7c) doesn't crash and doesn't display any fault but I can't add a timer from Kodi... Over Webif no problems...

Kodi Log:

19:15:19.639 T:1944975824   ERROR: AddOnLog: Tvheadend HTSP Client: pvr.hts - Command addDvrEntry failed: Could not add dvrEntry
19:15:19.639 T:1944975824   ERROR: PVR - AddTimer - addon 'Tvheadend:192.168.160.1:9982' returned an error: server error
19:15:19.639 T:1944975824   ERROR: PVR - AddTimer - cannot add timer to client '2146250725': server error

I can confirm this.

The debug logs show..

2018-01-13 18:31:49.789 [  TRACE]:htsp-req: 192.168.1.151 [  | Kodi Media Center ] - request '{"eventId":1982639,"enabled":1,"startExtra":0,"stopExtra":0,"removal":92,"retention":2147483646,"priority":2,"seq":184,"method":"addDvrEntry"}'
2018-01-13 18:31:49.789 [  TRACE]:htsp-ans: 192.168.1.151 [  | Kodi Media Center ] - answer '{"error":"Could not add dvrEntry","success":0,"seq":184}'

Just noticed this too after updating to 4.3-943~g9b85e7b7c.

Recordings that were already scheduled are running fine, but if you go into the DVR tab on the WebGUI and try to press i for more information nothing happens.

Adding new recordings from the web GUI crashes TVHeadend totally.

i can confirm a crash and posted my relevant logs here : [[http://tvheadend.org/boards/5/topics/30821]]

diff --git a/src/api/api_dvr.c b/src/api/api_dvr.c
index 336f315ad..cbc4d781c 100644
--- a/src/api/api_dvr.c
++ b/src/api/api_dvr.c
@ -227,7 +227,7 @ api_dvr_entry_create_by_event
conf = htsmsg_create_map();
htsmsg_copy_field(conf, "enabled", m, NULL);
htsmsg_copy_field(conf, "comment", m, NULL);
- htsmsg_add_str(conf, "owner", perm->aa_username);
htsmsg_add_str(conf, "owner", perm->aa_username ?: "");
htsmsg_add_str(conf, "creator", perm->aa_representative);
config_uuid = htsmsg_get_str(m, "config_uuid");
de = NULL;

Will this be pushed to git so that I can just do a git pull and rebuild?

Thanks. Will not build though?

dalton@tvburk:~/devel/tvh43/tvheadend> git pull
remote: Counting objects: 44, done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 44 (delta 38), reused 44 (delta 38), pack-reused 0
Unpacking objects: 100% (44/44), done.
From https://github.com/tvheadend/tvheadend
9b85e7b7c..33aac520c master > origin/master
Updating 9b85e7b7c..33aac520c
Fast-forward
src/api/api_dvr.c | 16 ++--
src/epggrab/otamux.c | 49 +++------------
src/htsmsg.c | 10 +++
src/htsmsg.h | 1 +
src/htsp_server.c | 28 +++-----
src/idnode.c | 2
src/input/mpegts.h | 1 +
src/input/mpegts/dvb_psi.c | 29 ++-------
src/input/mpegts/iptv/iptv.c | 13 +---
src/input/mpegts/iptv/iptv_udp.c | 9 +-
src/input/mpegts/linuxdvb/linuxdvb_frontend.c | 10 +-
src/input/mpegts/mpegts_input.c | 36 +++--------
src/input/mpegts/mpegts_mux.c | 81 ++++++++++----------------
src/input/mpegts/mpegts_mux_dvb.c | 5 +
src/input/mpegts/mpegts_network_scan.c | 12 +--
src/input/mpegts/mpegts_service.c | 11 +--
src/input/mpegts/mpegts_table.c | 4 +
src/input/mpegts/mpegts_tsdebug.c | 6 +
src/input/mpegts/satip/satip_frontend.c | 10 +--
src/notify.c | 2
src/profile.c | 40 ++++++------
src/subscriptions.c | 8 -
22 files changed, 150 insertions(), 233 deletions()
dalton@tvburk:~/devel/tvh43/tvheadend> make
make -f Makefile.webui LANGUAGES="ach ady ar bg cs da de en_US en_GB es et fa fi fr he hr hu it ko lv lt nl no pl pt ro ru sl sk sq sv tr uk zh zh-Hans" all
make¹: Entering directory '/home/dalton/devel/tvh43/tvheadend'
make -f Makefile.webui WEBUI=std compile-std
make²: Entering directory '/home/dalton/devel/tvh43/tvheadend'
WEBUI std finished
make²: Leaving directory '/home/dalton/devel/tvh43/tvheadend'
make -f Makefile.webui WEBUI=debug compile-debug
make²: Entering directory '/home/dalton/devel/tvh43/tvheadend'
WEBUI debug finished
make²: Leaving directory '/home/dalton/devel/tvh43/tvheadend'
make¹: Leaving directory '/home/dalton/devel/tvh43/tvheadend'
CC src/version.o
CC src/uuid.o
CC src/main.o
CC src/tvhlog.o
CC src/idnode.o
CC src/prop.o
CC src/proplib.o
CC src/utils.o
CC src/wrappers.o
CC src/tvhvfs.o
CC src/access.o
CC src/tcp.o
CC src/udp.o
CC src/url.o
CC src/http.o
CC src/notify.o
CC src/file.o
CC src/epg.o
CC src/epgdb.o
CC src/epggrab.o
CC src/spawn.o
CC src/packet.o
CC src/streaming.o
CC src/channels.o
CC src/subscriptions.o
CC src/service.o
CC src/htsp_server.o
CC src/htsmsg.o
src/htsmsg.c: In function ‘htsmsg_set_str2’:
src/htsmsg.c:467:1: error: control reaches end of non-void function [-Werror=return-type]
}
^
cc1: all warnings being treated as errors
Makefile:714: recipe for target '/home/dalton/devel/tvh43/tvheadend/build.linux/src/htsmsg.o' failed
make: *** [/home/dalton/devel/tvh43/tvheadend/build.linux/src/htsmsg.o] Error 1
dalton@tvburk:~/devel/tvh43/tvheadend>

It's fixed.