Project

General

Profile

Bug #4809

SAT>IP: Hanging pids when changing channels?

Added by Marc Postema almost 7 years ago. Updated almost 7 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Jaroslav Kysela
Category:
SAT>IP
Target version:
-
Start date:
2017-12-22
Due date:
% Done:

0%

Estimated time:
Found in version:
Last commit
Affected Versions:

Description

Hello,

I have some questions according these sequence: 

When starting a stream TvHeadend is sending an SETUP (note no: "&pids=" statement):
    SETUP rtsp://192.168.0.110/?fe=5&freq=610&sr=6900&msys=dvbc&mtype=256qam&fec=35

After this the pids are added by sending PLAY:
    PLAY rtsp://192.168.0.110/stream=0?addpids=0,1,16,17,18,2000,2001,2011,2012,2101,2102,2103,8187
    Session: 0265641043

Changing to another channel the following is send (note no: "&pids=" statement again):
    SETUP rtsp://192.168.0.110/stream=0?fe=5&freq=610&sr=6900&msys=dvbc&mtype=256qam&fec=35
    Session: 0265641043

After this the pids are added by sending PLAY:
    PLAY rtsp://192.168.0.110/stream=0?addpids=0,1,16,17,18,2300,2301,2311,2312,2401,2402,2403,8187
    Session: 0265641043

My questions are these:
    - Why are the old pids not deleted (with "pids=" statement) ?
    - Is this according to the specs?

My understanding of the specs is this:
    - An "pids=" statement will/must replace all previouse list
    - That when changing channels at least the "pids=" statement should be
      send to prevent hanging pids

The specs also state:
    - An in-session SETUP without a query in the RTSP URI shall not modify the list of PIDs to be filtered
      BUT DOES THIS MEAN when there is, the pid list must be cleared as well?
      AND THEREFORE THIS IS correct what TvHeadend is doing?

Can someone clear up this issue for me?

History

#1

Updated by Jaroslav Kysela almost 7 years ago

Do you know about any SAT>IP server which does not clear the PIDs list after the new SETUP ? You can check the active PIDs using 'grep "satip: Status string:"'.

#2

Updated by Jaroslav Kysela almost 7 years ago

Replying myself: We have already pids0 and pids21 hacks in the code.. Perhaps, we can enable pids=0 behaviour by default.

#3

Updated by Marc Postema almost 7 years ago

Jaroslav Kysela wrote:

Do you know about any SAT>IP server which does not clear the PIDs list after the new SETUP ? You can check the active PIDs using 'grep "satip: Status string:"'.

Yes, SatPI does this at the moment. I have not seen an client not adding
the "pids=" statement with an channel change by the way (or using an SETUP).

But is this required according the specs, deleting the pid list?
even though the "pids=" statement is not present?

#4

Updated by Jaroslav Kysela almost 7 years ago

SETUP with pids=0 was added to v4.3-847-g1156bf174 and v4.2.5-3-gfdb342e99 .

#5

Updated by Marc Postema almost 7 years ago

Jaroslav Kysela wrote:

SETUP with pids=0 was added to v4.3-847-g1156bf174 and v4.2.5-3-gfdb342e99 .

Yes thanks, and the code looks also cleaner now.
It is also possible to clean the pid list with "pids=none" by the way.

But I think this looks better according the specs.

#6

Updated by Mono Polimorph almost 7 years ago

Hi,

I agree that this optional value for forcing "pids=0" in SETUP commands can fix the SAT>IP interaction with some servers.

Thank you Jaroslav for your good work! ;)

#7

Updated by Jaroslav Kysela almost 7 years ago

  • Status changed from New to Fixed

Also available in: Atom PDF