Feature #4610: SAT>IP: Impersonate hardware server - Tvheadend

Feature #4610

SAT>IP: Impersonate hardware server

Added by Mono Polimorph about 7 years ago. Updated about 7 years ago.

Status:

Fixed

Priority:

Normal

Assignee:

Jaroslav Kysela

Category:

SAT>IP

Target version:

Start date:

2017-09-19

Due date:

% Done:

100%

Estimated time:

Description

Hi,

In order to impersonate a hardware SAT>IP server with the objective of use TVH with a software SAT>IP client that works only with this specific server. For this reason I developed a patch that enables the option for use a custom RTSP name for the server.

Here the patch:

diff --git a/src/satip/rtsp.c b/src/satip/rtsp.c
index 9b5a87d..c87cdc9 100644
--- a/src/satip/rtsp.c
+++ b/src/satip/rtsp.c
@@ -1251,7 +1251,7 @@ rtsp_describe_session(session_t *rs, htsbuf_queue_t *q)
   char buf[4096];

   htsbuf_qprintf(q, "a=control:stream=%d\r\n", rs->stream);
-  htsbuf_append_str(q, "a=tool:tvheadend\r\n");
+  htsbuf_qprintf(q, "a=tool:%s\r\n", config.http_server_name ?: "HTS/tvheadend");
   htsbuf_append_str(q, "m=video 0 RTP/AVP 33\r\n");
   if (strchr(rtsp_ip, ':'))
     htsbuf_append_str(q, "c=IN IP6 ::0\r\n");

The modification is quite simple. It uses the configured name in the "a=tool:" paremeter in RTSP responses. And if the name isn't configured then it uses the default name.

I feel you like to incorporate as it can be useful for system interoperability.
Regards!

Files

SAT-IP-Use-configured-server-name.diff (558 Bytes) SAT-IP-Use-configured-server-name.diff

simple patch

Mono Polimorph, 2017-09-19 10:44

History

Updated by Mono Polimorph about 7 years ago

Hi,

I hope you can commit this patch. I'm using it with my new patch #4617.
Both very useful for log/impersonate a hardware SAT>IP server.

Please, accept it!

Updated by Mark Clarkstone about 7 years ago

Mono Polimorph wrote:

.. snip ..

It's awesome that you're writing patches for Tvheadend, but as Jaroslav already said, patches via issues will take more of his time compared to a git pull request (and be a lot slower). I know git isn't for everyone, it wasn't for me at first, but once you get used to it, it's really awesome, in fact most of the things I learnt about git were from Jaroslav.

Honestly, it makes things so much easier, this is by no means a message telling you not give patches this way, just that it will take longer for them to be committed as they need to be done manually.

Updated by Mono Polimorph about 7 years ago

Mark Clarkstone wrote:

Mono Polimorph wrote:

.. snip ..

Honestly, it makes things so much easier, this is by no means a message telling you not give patches this way, just that it will take longer for them to be committed as they need to be done manually.

I know! Sorry! The problem is now I can't use GitHub. Believe me, I'll do when I can.
I like to contribute...

Updated by Mark Clarkstone about 7 years ago

Mono Polimorph wrote:

Mark Clarkstone wrote:

Mono Polimorph wrote:

.. snip ..

Honestly, it makes things so much easier, this is by no means a message telling you not give patches this way, just that it will take longer for them to be committed as they need to be done manually.

I know! Sorry! The problem is now I *can't use GitHub. Believe me, I'll do when I can.*
I like to contribute...

No need to apologise! It's a shame you can't though, some sort of block I guess? :/

Updated by Mono Polimorph about 7 years ago

Mono Polimorph wrote:

Hi,

In order to impersonate a hardware SAT>IP server with the objective of use TVH with a software SAT>IP client that works only with this specific server. For this reason I developed a patch that enables the option for use a custom RTSP name for the server.

Hi Jaroslav,

Don't forget this other patch either!