Project

General

Profile

Feature #4476

Feature #4505: SAT>IP: configurable RTP/AVP/TCP support

SAT>IP: Patch for disable RTP/AVP/TCP

Added by Mono Polimorph over 7 years ago. Updated over 7 years ago.

Status:
Rejected
Priority:
Normal
Category:
SAT>IP
Target version:
-
Start date:
2017-07-07
Due date:
% Done:

0%

Estimated time:

Description

Hi,

The current implementation of the SAT>IP server is amaizing. And the support of the RTP-over-TCP is interesting when using it with Wifi networks. However, I like to protect my server from clients that like to use TCP when I don't like it. So I created a patch that adds the option for disable the RTP-over-TCP support. It's optional.

If you like, use it!

---
 src/satip/rtsp.c   |    2 +-
 src/satip/server.c |   10 ++++++++++
 src/satip/server.h |    1 +
 3 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/satip/rtsp.c b/src/satip/rtsp.c
index e08c626..ba16f81 100644
--- a/src/satip/rtsp.c
+++ b/src/satip/rtsp.c
@@ -857,7 +857,7 @@ parse_transport(http_connection_t *hc)
     if (a + 1 != b)
       return -1;
     return a;
-  } else if (strncmp(s, "RTP/AVP/TCP;interleaved=0-1", 27) == 0) {
+  } else if ((strncmp(s, "RTP/AVP/TCP;interleaved=0-1", 27) == 0) && !satip_server_conf.satip_notcp_mode) {
     return RTSP_TCP_DATA;
   }
   return -1;
diff --git a/src/satip/server.c b/src/satip/server.c
index c429056..e6a39d2 100644
--- a/src/satip/server.c
+++ b/src/satip/server.c
@@ -717,6 +717,16 @@ const idclass_t satip_server_class = {
       .group  = 1,
     },
     {
+      .type   = PT_BOOL,
+      .id     = "satip_notcp_mode",
+      .name   = N_("RTP/AVP/TCP (embedded data)"),
+      .desc   = N_("Disable server support for RTP/AVP/TCP transfer mode " 
+                   "(embedded data in the RTSP session)."),
+      .off    = offsetof(struct satip_server_conf, satip_notcp_mode),
+      .opts   = PO_EXPERT,
+      .group  = 1,
+    },
+    {
       .type   = PT_U32,
       .id     = "satip_iptv_sig_level",
       .name   = N_("IPTV signal level"),
diff --git a/src/satip/server.h b/src/satip/server.h
index 471027f..f228f60 100644
--- a/src/satip/server.h
+++ b/src/satip/server.h
@@ -47,6 +47,7 @@ struct satip_server_conf {
   int satip_rewrite_pmt;
   int satip_muxcnf;
   int satip_nom3u;
+  int satip_notcp_mode;
   int satip_anonymize;
   int satip_iptv_sig_level;
   int satip_force_sig_level;
--
1.7.10.4

History

#1

Updated by Mono Polimorph over 7 years ago

Hi,

I feel the name in this patch is wrong.
The NAME needs to say "Disable RTP/AVP/TCP (embedded data) support"

Why you need this patch? To disable the transmission of the RTP stream over TCP. And yes, this can be requested by the client... and this patch limits this. Also it makes the SAT>IP server conformant with the SAT>IP standard.

Please, you agree to commit this patch? ;)

#2

Updated by Mono Polimorph over 7 years ago

Please, close this issue as #4505 replaces this! ;)

#3

Updated by Jaroslav Kysela over 7 years ago

  • Status changed from New to Rejected
  • Parent task set to #4505

Also available in: Atom PDF