Feature #4448
SAT>IP signal level for IPTV sources
100%
Description
Hi,
We want to comment after reviewing the commit “satip server: increase the signal level strenght for the uknown state”:
https://tvheadend.org/projects/tvheadend/repository/revisions/63024099252c62553baef05f1b2d3c3aed22e865
We like to publish one simple patch to “improve” (not to fix) the signal level from IPTV sources reported to SAT>IP clients.
This is the patch (SATIP_IPTV_tunning_fix-patch.diff):
--- tvheadend/src/satip/rtp.c 2016-04-04 13:26:25.900840325 +0200 +++ tvheadend/src/satip/rtp.c 2016-04-04 13:27:11.773352106 +0200 @@ -487,10 +487,10 @@ void satip_rtp_queue(void *id, th_subscr socket_set_dscp(rtp->fd_rtcp, dscp, NULL, 0); if (perm_lock) { rtp->sig.signal_scale = SIGNAL_STATUS_SCALE_RELATIVE; - rtp->sig.signal = 0xa000; + rtp->sig.signal = 0xfa00; rtp->sig.snr_scale = SIGNAL_STATUS_SCALE_RELATIVE; - rtp->sig.snr = 28000; + rtp->sig.snr = 61440; } tvhtrace("satips", "rtp queue %p", rtp);
It sets signal quality and strength to nearly 100%.
We understand why the original developer has used a lower value. With a very low value you can check in the client the real source of the stream. So, if you mix “real” tuners with IPTV sources, then good frequencies with a very low signal are IPTV.
However, we think it’s better to leave the user to decide if his like to use an “special” signal value or “regular” (~100%) signal for IPTV sources. Then, we suggest to add one configuration integer value for selecting the “SAT>IP Signal Strength for IPTV sources”.
In any case, if you like to use our patch, feel free to use it.
Regards,
D.
History
Updated by Jaroslav Kysela over 7 years ago
- Status changed from New to Fixed
- % Done changed from 0 to 100
Applied in changeset commit:tvheadend|2f5009e0717fd4747c140a93d61ffe2980c06373.
Updated by DSA APF over 7 years ago
Jaroslav Kysela wrote:
Applied in changeset commit:tvheadend|2f5009e0717fd4747c140a93d61ffe2980c06373.
Thank you!
D.
Updated by Mark Clarkstone over 7 years ago
DSA APF wrote:
Jaroslav Kysela wrote:
Applied in changeset commit:tvheadend|2f5009e0717fd4747c140a93d61ffe2980c06373.
Thank you!
D.
DSA APF, If you have any more patches you may find it easier to just open a PR on github :).
Updated by DSA APF over 7 years ago
Mark Clarkstone wrote:
DSA APF, If you have any more patches you may find it easier to just open a PR on github :).
Yes, we know. However, for small patches a simple DIFF file is more comfortable! ;)
Futhermore, in some cases we have already done so.
We hope you don't reject our contribution because this.
D.
Updated by Mark Clarkstone over 7 years ago
DSA APF wrote:
Mark Clarkstone wrote:
DSA APF, If you have any more patches you may find it easier to just open a PR on github :).
Yes, we know. However, for small patches a simple DIFF file is more comfortable! ;)
Futhermore, in some cases we have already done so.We hope you don't reject our contribution because this.
It was merely a suggestion, I'm sure Jaroslav is happy to receive any patches no matter where they come from :).
D.