Project

General

Profile

Feature #4349

'pass' string change - fixes .ts thumbnail generation

Added by David B over 7 years ago. Updated almost 7 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-05-02
Due date:
% Done:

0%

Estimated time:

Description

Hi tvh development team,

'pass' string change - fixes .ts thumbnail generation

Please consider a small 'pass' default string change which has a large impact
.$x changes internally from...
- .ts
+ .m2ts

This simple change fixes thumbnail generation issues for Ubuntu based OS, instead of transport stream files with .ts extension being incorrectly identified as 'message catalogue', they are correctly identified as 'MPEG-2 transport stream' allowing thumbnail generation. Also removes the need for .local custom mime-types to fix thumbnail generation.

Can be tested by changing files .ts extension, or temporarily changing tvh recording string from .$x to .m2$x

Thank you in advance

History

#1

Updated by David B over 7 years ago

Rather than "fixes", maybe should have written... circumvents the transport stream thumbnail issue.

#2

Updated by Hanspeter Müller over 7 years ago

Strongly disagree with this one, it is never a good idea to cover up one f***up with another, just ask Sean Spicer ;) .

It will blow up in someones face (the more stupid OSes out there, like the one from that obscure company in Redmond, who only look at the extension probably wont like that) one way or the other...

IMHO it makes a lot more sense to document this bug in ubuntu (which btw i don't see in LinuxMint, i'm not getting thumbnails on eighter ts nor m2ts) in the wiki.

my two cents...

/hp

#3

Updated by Joe User over 7 years ago

But ".ts" files are not always mpeg-2. :) ".ts" means "Transport Stream" and covers ALL content.
The ".ts" extension is well know and most commonly used everywhere, to change it would cause lots of problems for people relying on the (correct) extension of ".ts" for transport stream recordings.

This is an OS (Ubuntu) issue and should be solved there...

#4

Updated by David B over 7 years ago

Thanks for your replies,

Will abandon this idea then. First considered (and was using) .mts, but noticed .m2ts mentioned/used more frequently, Wikipedia mentions MPEG transport stream (ts) extended to .m2ts. My bad, assumed they were different extensions for the same encoding!
Back to using ~/.local mime-type then. :)

While testing, noticed Kubuntu 17.04 doesn't seem to have a .ts thumbnail issue, maybe there's been an upstream fix, or since mime-types seem the same, a thumbnail generation modification/improvement? Will test other Ubuntu based 17.04 editions in few days and report back.

#5

Updated by Jaroslav Kysela over 7 years ago

  • Status changed from New to Rejected
#6

Updated by David B almost 7 years ago

Must apologise, mentioned I'd report back and didn't. Tested few other Ubuntu based distributions with VirtualBox, they handled my .ts test files in the same way. Few hours ago, tested Kubuntu 17.10 as a live session (bare metal) most of my .ts test files were incorrectly identified as a text file, but one was correctly identified as a video and its thumbnail was generated.

Experimented with using a ~/.local mime-type, but (even though may be seen as an incorrect approach) decided to return to previous method of changing Tvheadend's pass string, so all recordings have a .mts suffix, and all files automatically generate thumbnails without further user intervention.

Also available in: Atom PDF