Project

General

Profile

Bug #4142

picon - dont work regenerte id/name

Added by piotr galek almost 8 years ago. Updated almost 8 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
General
Target version:
-
Start date:
2016-12-18
Due date:
% Done:

0%

Estimated time:
Found in version:
4.1-2389~gf49ea87
Affected Versions:

Description

Hi
im using latest version
4.1-2389~gf49ea87 from master

yesterday im made new config, preset everything like in old one
setup url of picon etc. but in channels/EPG in column picon - name are not any more create automatical

here screen from old version

here from new one

config in main/general for picon same:
[[ "prefer_picon": true,
"chiconscheme": 0,
"piconpath": "https://raw.githubusercontent.com/piotrasd/picons-e2/master",
"piconscheme": 1,]]

dont help change that settings save and reset picon, or disable completly, give new custom name of picons in channels after that use button reset picon
and restart whole tvheadend etc.

all time i have empty space in channels in picon urls :(

History

#1

Updated by Jaroslav Kysela almost 8 years ago

Screenshots are not here and it's a bit unclear what does not work.

#3

Updated by piotr galek almost 8 years ago

ohh and dont work generate names like picon://1_0_1_12C7_2E7C_13E_820000_0_0_0.png
reseting picon, chnage setting in general - > picon - dont work whole time i have empy space - where before without problem tvheadend generate name like
"picon://1_0_1_12C7_2E7C_13E_820000_0_0_0.png"

#4

Updated by piotr galek almost 8 years ago

UPDATE: when you map new channels - then picon name is automatical generated - but is no possible reset - regenerate when you was before mapped

#5

Updated by Jaroslav Kysela almost 8 years ago

Because '"prefer_picon": true' TVH uses the picons by default (when the named channel logos are not available). If you compile tvh with the image cache, the picon://REST is redirected to https://raw.githubusercontent.com/piotrasd/picons-e2/master/REST when the logo is downloaded (but it's not visible in the webui).

So, what does not work ? It seems that you're just confused how things are supposed to work.

The screenshots are not available. You're using probably your credentals for dropbox - provide a public URL.

#6

Updated by piotr galek almost 8 years ago

Ok maybe now you better understand me.
I know how picons works becuase on older version was fine ;)

https://youtu.be/9hmW8AheBZY

#7

Updated by piotr galek almost 8 years ago

and now old version where working

https://youtu.be/lgDbXNwDFJY

i hope now you will see diffrence :)

#8

Updated by Jaroslav Kysela almost 8 years ago

I cannot reproduce this here, the channels from 13E generates right URLs in the channel grid here. Could you apply this patch and provide the log snippet when you are trying to reset the icon URL for one channel?

iff --git a/src/channels.c b/src/channels.c
index b483ab6..fb436b8 100644
--- a/src/channels.c
+++ b/src/channels.c
@@ -906,6 +906,7 @@ channel_get_icon ( channel_t *ch )
     if (pick && picon) {
       LIST_FOREACH(ilm, &ch->ch_services, ilm_in2_link) {
         if (!(icn = service_get_channel_icon((service_t *)ilm->ilm_in1))) continue;
+        tvhwarn(LS_CHANNEL, "svc get icon: '%s'", icn);
         if (strncmp(icn, "picon://", 8))
           continue;
         snprintf(buf2, sizeof(buf2), "%s/%s", picon, icn+8);
@@ -917,10 +918,14 @@ channel_get_icon ( channel_t *ch )
       }
     }

+    tvhwarn(LS_CHANNEL, "iter %d picon %p icon '%s'", i, picon, icon);
+
   }

 found:

+  tvhwarn(LS_CHANNEL, "end: '%s'", icon);
+
   /* Nothing */
   if (!icon || !*icon)
     return NULL;
#10

Updated by piotr galek almost 8 years ago

im using converter script from E2 to tvheadend this one -
https://www.sendspace.com/file/z00kqv

and i never had on older version tvheadend problem with reset picon

here my actual list after conversion
https://www.sendspace.com/file/m18jqa (maybe you can test on they)

im using this script becuase is one which working good bouquest creation and channels numbering.
(btw. maybe you can add this tool to tvheadend for more easy import channels from E2, this really good working)

#11

Updated by Jaroslav Kysela almost 8 years ago

The culprit is probably that your network has not assigned the orbital position. The converter should be fixed.

#12

Updated by piotr galek almost 8 years ago

@Jaroslav Kysela thx .... and true :) after check in networks setting orbital position and switch, picons works !
thanks for you time and sorry :( for bother

#13

Updated by Jaroslav Kysela almost 8 years ago

  • Status changed from New to Rejected

Also available in: Atom PDF