Bug #3807
Channel icon: translate '/' character (filename)
100%
Description
I am using the following setting:
Channel icon path: file:///home/hts/channelIcons/%C.png
It works fine for every icon but the ones that contains a plus (+ - like Canal+, ...). Under channel in the column "user icon" the mapping between the channel and the file is done properly but the imagecache/id returns nothing.
As this used to work fine in 4.0.7, I am pretty sure that this commit is responsible for the regression: https://github.com/tvheadend/tvheadend/commit/a95317543b952d756ff237a16f8801c504883251. It looks like the + wrongly being unescaped.
History
Updated by Jaroslav Kysela over 8 years ago
- Subject changed from Channel icon: %C does not handle + char properly to 4.0: Channel icon: %C does not handle + char properly
This issue was fixed in 4.1 and it won't be fixed in 4.0.
Updated by FuN KeY over 8 years ago
Thanks for information.
I moved to master (4.1-2047~g5dfc7d5) and I have a very similar problem with channel containing spaces and %c (urlEncode) setting.
Channel without space works fine
Updated by Jaroslav Kysela over 8 years ago
Config:
Prefer picons over channel name: unchecked Channel icon path: file:///home/perex/icons/%c.png Channel icon name scheme: No scheme
Web interface:
file:///home/perex/icons/Prima%20HD.png
TVH tries to open this file:
open: '/home/perex/icons/Prima HD.png'
I don't see a problem. The file:// URL is deescaped before the file is opened.
Updated by FuN KeY over 8 years ago
Okay, I did understand the logic wrong. I did escape the name of the png.
My file was named '/home/perex/icons/Prima%20HD.png'
In that context it did map automatically in the "user icon" column but the file was never opened properly.
I will then URL decode all my file name and see how it looks.
Thanks !
Updated by FuN KeY over 8 years ago
I did unescape all my logo & updated TVH master to 4.1-2051~gc514879 and it still does not work.
Mapping in "user icon" is done properly, but I do not get any icon for channel that contains spaces, ...
I get:
HTTP/1.1 GET /imagecache/301 -- 404
How did you achieve to display the actual path of the file that TVH tried to open?
Updated by FuN KeY over 8 years ago
Okay, I did completely clear my config and start from scratch; from there it works fine!
There is one last catch. I do have the channel "BBC Four / CBeebies" that contains a /. As this char is not allowed in filename I cannot create a file with the expected name. Is there any workaround for that?
Cheers !
Updated by Jaroslav Kysela over 7 years ago
- Subject changed from 4.0: Channel icon: %C does not handle + char properly to Channel icon: translate '/' character (filename)
- Found in version changed from 4.09 to 4.x
Updated by Jaroslav Kysela over 7 years ago
- Status changed from New to Fixed
- % Done changed from 0 to 100
Applied in changeset commit:tvheadend|6a3cb59a8d15af445803ef68489638cd4549c7e2.