Project

General

Profile

Bug #3521

Compile error: Fails to build with --disable-iptv

Added by just bkifft almost 9 years ago. Updated almost 9 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
General
Target version:
-
Start date:
2016-01-22
Due date:
% Done:

100%

Estimated time:
Found in version:
current master (1aa0073be39119f5d0d79212e6c83c470904a161)
Affected Versions:

Description

src/wizard.c has hard references to iptv_auto_network_class even if ./configure'd with --disable-iptv, resulting in the following linker error:

/usr/src/tvheadend/build.linux/src/wizard.o: In function `muxes_save':
/usr/src/tvheadend/src/wizard.c:732: undefined reference to `iptv_auto_network_class'
/usr/src/tvheadend/src/wizard.c:732: undefined reference to `iptv_auto_network_class'
/usr/src/tvheadend/build.linux/src/wizard.o: In function `wizard_muxes':
/usr/src/tvheadend/src/wizard.c:926: undefined reference to `iptv_auto_network_class'
/usr/src/tvheadend/src/wizard.c:926: undefined reference to `iptv_auto_network_class'
collect2: error: ld returned 1 exit status
Makefile:570: recipe for target '/usr/src/tvheadend/build.linux/tvheadend' failed
make: *** [/usr/src/tvheadend/build.linux/tvheadend] Error 1

History

#1

Updated by Jaroslav Kysela almost 9 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset commit:tvheadend|e85cad034fa14a27f9eee607de222fea62e06181.

#2

Updated by just bkifft almost 9 years ago

Sadly the fix introduced new errors, unused-variables to be precise:

CC              src/wizard.o
src/wizard.c: In function 'muxes_save':
src/wizard.c:721:13: error: unused variable 'm' [-Werror=unused-variable]
   htsmsg_t *m;
             ^
src/wizard.c: In function 'wizard_muxes':
src/wizard.c:890:27: error: unused variable 'iptvprops' [-Werror=unused-variable]
   static const property_t iptvprops[] = {
                           ^
#3

Updated by Jaroslav Kysela almost 9 years ago

Try v4.1-1451-gf074688 .

#4

Updated by just bkifft almost 9 years ago

New patch, new error:

CC              src/wizard.o
src/wizard.c:844:20: error: 'muxes_get_iptv_value1' defined but not used [-Werror=unused-function]
 static const void *muxes_get_iptv_value##num(void *o) \
                    ^
src/wizard.c:859:1: note: in expansion of macro 'MUXES_FCN'
 MUXES_FCN(1)
 ^
src/wizard.c:851:12: error: 'muxes_set_iptv_value1' defined but not used [-Werror=unused-function]
 static int muxes_set_iptv_value##num(void *o, const void *v) \
            ^
src/wizard.c:859:1: note: in expansion of macro 'MUXES_FCN'
 MUXES_FCN(1)
 ^
src/wizard.c:844:20: error: 'muxes_get_iptv_value2' defined but not used [-Werror=unused-function]
 static const void *muxes_get_iptv_value##num(void *o) \
                    ^
src/wizard.c:860:1: note: in expansion of macro 'MUXES_FCN'
 MUXES_FCN(2)
 ^
src/wizard.c:851:12: error: 'muxes_set_iptv_value2' defined but not used [-Werror=unused-function]
 static int muxes_set_iptv_value##num(void *o, const void *v) \
            ^
src/wizard.c:860:1: note: in expansion of macro 'MUXES_FCN'
 MUXES_FCN(2)
 ^
src/wizard.c:844:20: error: 'muxes_get_iptv_value3' defined but not used [-Werror=unused-function]
 static const void *muxes_get_iptv_value##num(void *o) \
                    ^
src/wizard.c:861:1: note: in expansion of macro 'MUXES_FCN'
 MUXES_FCN(3)
 ^
src/wizard.c:851:12: error: 'muxes_set_iptv_value3' defined but not used [-Werror=unused-function]
 static int muxes_set_iptv_value##num(void *o, const void *v) \
            ^
src/wizard.c:861:1: note: in expansion of macro 'MUXES_FCN'
 MUXES_FCN(3)
 ^
src/wizard.c:844:20: error: 'muxes_get_iptv_value4' defined but not used [-Werror=unused-function]
 static const void *muxes_get_iptv_value##num(void *o) \
                    ^
src/wizard.c:862:1: note: in expansion of macro 'MUXES_FCN'
 MUXES_FCN(4)
 ^
src/wizard.c:851:12: error: 'muxes_set_iptv_value4' defined but not used [-Werror=unused-function]
 static int muxes_set_iptv_value##num(void *o, const void *v) \
            ^
src/wizard.c:862:1: note: in expansion of macro 'MUXES_FCN'
 MUXES_FCN(4)
 ^
src/wizard.c:844:20: error: 'muxes_get_iptv_value5' defined but not used [-Werror=unused-function]
 static const void *muxes_get_iptv_value##num(void *o) \
                    ^
src/wizard.c:863:1: note: in expansion of macro 'MUXES_FCN'
 MUXES_FCN(5)
 ^
src/wizard.c:851:12: error: 'muxes_set_iptv_value5' defined but not used [-Werror=unused-function]
 static int muxes_set_iptv_value##num(void *o, const void *v) \
            ^
src/wizard.c:863:1: note: in expansion of macro 'MUXES_FCN'
 MUXES_FCN(5)
 ^
src/wizard.c:844:20: error: 'muxes_get_iptv_value6' defined but not used [-Werror=unused-function]
 static const void *muxes_get_iptv_value##num(void *o) \
                    ^
src/wizard.c:864:1: note: in expansion of macro 'MUXES_FCN'
 MUXES_FCN(6)
 ^
src/wizard.c:851:12: error: 'muxes_set_iptv_value6' defined but not used [-Werror=unused-function]
 static int muxes_set_iptv_value##num(void *o, const void *v) \
            ^
src/wizard.c:864:1: note: in expansion of macro 'MUXES_FCN'
 MUXES_FCN(6)
 ^
#5

Updated by Jaroslav Kysela almost 9 years ago

v4.1-1455-geccb003

#6

Updated by just bkifft almost 9 years ago

Thanks, fixed now. (And sorry for stumbling over such unimportant bugs :))

Also available in: Atom PDF