Project

General

Profile

Bug #2967

Channel icons not displaying for filenames with spaces

Added by John Doe over 9 years ago. Updated over 7 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
2015-06-23
Due date:
% Done:

0%

Estimated time:
Found in version:
4.0.5-4~g7a7b3b3
Affected Versions:

Description

I've added file:///home/hts/channelicons/%C.png as my 'Channel icon path' and it works very well, except all channels that have spaces in them do not get displayed.

E.g. channel 'NPO 1 HD' gets this link: file:///home/hts/channelicons/NPO%202%20HD.png

The filename in the specified directory is 'NPO 1 HD', the same as the channel name in TVH. I have never used the channel icon path option before, as before I had the icons manually set with URLs, so I'm not sure if other versions have this same problem.

Using %c.png instead makes saving awfully slow and doesn't update the icon path at all.

I also tried it on 4.1-276~g444654c-dirty and there it also didn't work.

History

#1

Updated by Piotr Kuchciak over 9 years ago

E.g. channel 'NPO 1 HD' gets this link: file:///home/hts/channelicons/NPO%202%20HD.png

icon file name should have _ (when is SPACE file name should have _)

'NPO 1 HD' gets this link: file:///home/hts/channelicons/NPO_1_HD.png

#2

Updated by Jaroslav Kysela over 9 years ago

The icon URL is updated only when it's empty or when user forces the url update ('Reset icon URL' button). There are no other automatic updates. So users may re-edit the URLs later.

The %c will use escaped URL - so you see %20 instead spaces, %C format uses underlines _ instead spaces. You created wrong URL probably using %c format instead %C format.

#3

Updated by John Doe over 9 years ago

Piotr Kuchciak wrote:

E.g. channel 'NPO 1 HD' gets this link: file:///home/hts/channelicons/NPO%202%20HD.png

icon file name should have _ (when is SPACE file name should have _)

'NPO 1 HD' gets this link: file:///home/hts/channelicons/NPO_1_HD.png

Yes, that's what I thought after your post, but when I delete the URL and save it so it resets I get %20 for spaces instead of underscores.

@Jaroslav, no I use %C, it still gives %20 for spaces instead of underscores.

Ok, just checked again, and it appears that this issue only happens in the master release I used (4.1-276~g444654c-dirty) the 4.0.5-4 version I run now works fine with underscores.

#4

Updated by Jaroslav Kysela over 9 years ago

Are you sure ? Just tried on latest v4.1-296-g8cc9b71 and everything seems ok...

Config: file:///home/icons/%C.png
Channel name: CT 2 HD
Result: file:///home/icons/CT_2_HD.png

I'm not aware about any change in this code recently.

#5

Updated by John Doe over 9 years ago

Jaroslav Kysela wrote:

Are you sure ? Just tried on latest v4.1-296-g8cc9b71 and everything seems ok...

[...]

I'm not aware about any change in this code recently.

Yep, I'm sure. I've restarted TVH a couple of times and changed everything related. I just installed 292 and it seems to work there as well. I guess this can be closed.

#6

Updated by Jaroslav Kysela over 9 years ago

  • Status changed from New to Fixed
#7

Updated by ksya net over 7 years ago

I have exactly the same problem right now with 4.2.3-19~g490b6f2
Any idea why this is and how to fix it?
And yes, I use %C and have saved the settings. After that I reset the icons and saved the channel list, but still spaces become %20

#8

Updated by Jesus Jimenez over 7 years ago

ksya net wrote:

I have exactly the same problem right now with 4.2.3-19~g490b6f2
Any idea why this is and how to fix it?
And yes, I use %C and have saved the settings. After that I reset the icons and saved the channel list, but still spaces become %20

Can confirm the same issue. Path is set with %C, yet tvheadend is looking for paths with encoded spaces (%20) instead of underscores.

Using 4.2.3-19~g490b6f2 too from Ubuntu PPA repository.

#9

Updated by edit4ever ! over 7 years ago

Tvheadend is now looking for actual spaces - no need for underscore or %20

Just put the actual space in the name of the file.

#10

Updated by Jesus Jimenez over 7 years ago

edit4ever ! wrote:

Tvheadend is now looking for actual spaces - no need for underscore or %20
Just put the actual space in the name of the file.

But documentation explicitly says that %C replaces spaces with underscores:

%C: The transliterated channel name in ASCII (safe characters, no spaces, etc. - so Das Erste HD will be Das_Erste_HD, but WDR Köln will be WDR_Koln)

#11

Updated by Mark Clarkstone over 7 years ago

Jesus Jimenez wrote:

edit4ever ! wrote:

Tvheadend is now looking for actual spaces - no need for underscore or %20
Just put the actual space in the name of the file.

But documentation explicitly says that %C replaces spaces with underscores:

%C: The transliterated channel name in ASCII (safe characters, no spaces, etc. - so Das Erste HD will be Das_Erste_HD, but WDR Köln will be WDR_Koln)

It needs updating :).

#12

Updated by Jesus Jimenez over 7 years ago

Mark Clarkstone wrote:

It needs updating :).

Ok, nice to know it's not a bug, it's a feature :-)

I created a pull request right now with updated documentation.

Thanks!

Also available in: Atom PDF