Bug #2700
Picon name generation is not correct
100%
Description
Hi,
I assume that Tvheadend picon file names should be fully compatible with Enigma 2 systems. However there are differences in file name generation which results that picons migrated from Enigma box will not be shown or only a part of them will be shown due to file name mismatch.
I found this explanation of picon filename:
__What does an example file name pointing to the .png file look like? 1_0_1_957_327B_3277_6400000_0_0_0.png = the Plicon of 1600e_golden_west_network.png
The file name, what does it mean?
1 = reftype, fixed
0 = flags, fixed
1 = servicetype (1=tv)
957 = SID
327B = transponder id
3277 = network id
6400000 = namespace (orbital position 1600 --> 640 hex)
0 = parent SID
0 = parent transponder id
0 = unused_
_
The main problem is with satellites on the west side. e.g. Thor 0,8W picon generated filename in Tvheadend look like this: 1_0_1_7601_2BE_600_FFF70000_0_0_0.png. The Enigma version is: 1_0_1_7601_2BE_600_E0800000_0_0_0.png
The difference is that TVH assigns FFF7 -> (-9 decimal?) while the picon has E08 -> 3592 (359.2 degree East)
So the problem is with the calculation of orbital position. This is a bug.
On the other hand the namespace part of the picon name is not always the satellite position with traling 0s. It sometimes contains discrimination values which makes possible to distuingish between two DVB services having similar SID/TID/NID.
Unfortunately I could not find a reliable algorithm how to generate the rigth DVB namespace value.
Files
History
Updated by Jaroslav Kysela over 9 years ago
- Status changed from New to Fixed
Fixed in v3.9-2506-g1bd1564 .
Updated by saen acro over 9 years ago
Jaroslav Kysela wrote:
Fixed in v3.9-2506-g1bd1564 .
on some services there is also strange naming
on hellas sat 2 39 degree
TVH search for 1_0_1_6E_4_1_1860000_0_0_0.png
in enigma for 1_0_1_6E_4_1_1863115_0_0_0.png
Updated by saen acro over 9 years ago
Jaroslav Kysela wrote:
Fixed in v3.9-2506-g1bd1564 .
on some services there is also strange naming
on hellas sat 2 39 degree
TVH search for 1_0_1_6E_4_1_1860000_0_0_0.png
in enigma2 for 1_0_1_6E_4_1_1863115_0_0_0.png
same channel Alpha TV
it happens in some other services on same satellite.
Updated by Akos Sz over 9 years ago
saen acro wrote:
Jaroslav Kysela wrote:
Fixed in v3.9-2506-g1bd1564 .
on some services there is also strange naming
on hellas sat 2 39 degreeTVH search for 1_0_1_6E_4_1_1860000_0_0_0.png
in enigma2 for 1_0_1_6E_4_1_1863115_0_0_0.png
same channel Alpha TV
it happens in some other services on same satellite.
This is what I meant when mentioned namespace and trailing zeros. Check my original post and attachment.
Updated by Jaroslav Kysela over 9 years ago
The hash calculation is here:
https://github.com/libo/Enigma2/blob/master/lib/dvb/frontend.cpp#L398-L419
But to make things more complicated, the low 16-bits are zeroed when ONID and TSID are validated:
https://github.com/libo/Enigma2/blob/master/lib/dvb/scan.cpp#L56-L157
Updated by Jaroslav Kysela over 9 years ago
Here is another validation from the http://git.opendreambox.org :
http://git.opendreambox.org/?p=obi/tuxbox-apps.git;a=blob;f=tuxbox/enigma/lib/dvb/dvbscan.cpp
Seems much simpler.
Updated by Jaroslav Kysela over 9 years ago
- Status changed from Fixed to Accepted
- Assignee set to Jaroslav Kysela
Updated by jenda benda over 9 years ago
- File picons.png picons.png added
Hi there,
are you sure it's fixed? I have installed latest git and generated name is still the same.
I tried to reset icons/save settings but the picon path will become the same. Is there a way how should I reset it or the picon name is still generated in wrong way?
Please see the attached picture.
Thanks a lot
Kind regards
j.
Updated by Jaroslav Kysela over 9 years ago
jenda benda wrote:
Hi there,
are you sure it's fixed? I have installed latest git and generated name is still the same.
I tried to reset icons/save settings but the picon path will become the same. Is there a way how should I reset it or the picon name is still generated in wrong way?
Please see the attached picture.Thanks a lot
Kind regards
You should select the channel in the channel configuration, then click to 'Reset Icon' and 'Save'.. The icons should be re-generated. Also, check, if you have correct orbital position assigned to the network (network grid) before.
Updated by saen acro over 9 years ago
3.9.2525 no change still zeroes
is there a possible to add some mark if picon or logo was been found
Updated by Jaroslav Kysela over 9 years ago
saen acro wrote:
3.9.2525 no change still zeroes
No idea. Could you show me the network settings ?
is there a possible to add some mark if picon or logo was been found
It might be useful indeed.
Updated by saen acro over 9 years ago
what settings exactly
am scanning hellas sat 39E bulsatcom pack some programs have "zeroes" problem
picon://1_0_1_6E_4_1_1860000_0_0_0.png is what is search
real is 1_0_1_6E_4_1_1863115_0_0_0
Updated by Jaroslav Kysela over 9 years ago
saen acro wrote:
what settings exactly
am scanning hellas sat 39E bulsatcom pack some programs have "zeroes" problempicon://1_0_1_6E_4_1_1860000_0_0_0.png is what is search
real is 1_0_1_6E_4_1_1863115_0_0_0
OK. So the satellite position is correct (0x186 = 390 -> 39E), the code (hacks) mentioned in comment#5 and comment#6 are not added yet to the tvheadend. So all lower values are zero at the moment. That's the reason why I re-opened the bug to take care when the SAT>IP Server code is merged.
Updated by Jaroslav Kysela over 9 years ago
- Status changed from Accepted to Fixed
- % Done changed from 0 to 100
Applied in changeset commit:tvheadend|e247500a080292b4c2a2f562fac9c30534753e50.