Project

General

Profile

Bug #2485

Limiting number of concurrent connections per user (also for DVR streaming)

Added by Rafal Kupiec almost 10 years ago. Updated over 9 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
General
Target version:
-
Start date:
2014-11-17
Due date:
% Done:

100%

Estimated time:
Found in version:
GIT
Affected Versions:

Description

There can be a limit of maximum concurrent connections set per user account.
This is working great, but affects only streaming. I think that this option should also affect DVR (recording).
If I set a limit to 1, then I imagine that single user will be able to use some % of available traffic, as well as 1 tunner.

I imagine, that recording won't start until user is watching some channel (other than being recorded) or that it will disconnect him, assuming DVR has a higher priority than playback. If I'd like to let user watch and recored another channel in the same time, I would like to increase this limit to 2.

History

#1

Updated by Rafal Kupiec almost 10 years ago

Or maybe even better... Temporarily give access to playback and recording at once if there are free tuners available.
But if new user connects and there is no free tuner left, then first check if any user is has exceeded his limit (counting both playback and recording). If this condition has been met, then disconnect him from playback and let only record his TV program.

However in this case, TVH would not allow to record more streams than limit set for single user and most probably additional option (for limiting recording) should be introduced.

#2

Updated by saen acro almost 10 years ago

http://www.fail2ban.org
with combination of Webmin

#3

Updated by Rafal Kupiec almost 10 years ago

saen acro wrote:

http://www.fail2ban.org
with combination of Webmin

This wont work as you think.
First of all I do not want to ban anyone, just block/allow playback/DVR function. At this time everyone with DVR enabled in his profile, can schedule recording for whatever he wants, so single user can schedule 4 different programs to be recorded at the same time. Fail2ban will not limit concurrent DVR sessions. That's what TVH should do.

#4

Updated by Rafal Kupiec almost 10 years ago

Lets say there are 2 tuners and 2 users. Everyone have set a limit of concurrent connections to 1.
This way everyone is able to watch 1 channel at once. However after enabling DVR, 1 user has the ability to watch 1 channel and record another one, thus 2nd user cannot watch anything because there is no tuner that is ready for use.

With this bug fixed, I imagine user won't be able to record one and watch another channel if this requires more 'connections' than limit set (1). But will still allow to play and record the same channel at the same time, or schedule recording (eg. at night when user is sleeping.

#5

Updated by saen acro almost 10 years ago

Rafal Kupiec wrote:

Lets say there are 2 tuners and 2 users. Everyone have set a limit of concurrent connections to 1.
This way everyone is able to watch 1 channel at once. However after enabling DVR, 1 user has the ability to watch 1 channel and record another one, thus 2nd user cannot watch anything because there is no tuner that is ready for use.

With this bug fixed, I imagine user won't be able to record one and watch another channel if this requires more 'connections' than limit set (1). But will still allow to play and record the same channel at the same time, or schedule recording (eg. at night when user is sleeping.

there is not problem to watch and record channels from same tuned transponders in same time
but let's say that DVR must bi different USER (internal for TVH) never mind with user is set recording

#6

Updated by Rafal Kupiec almost 10 years ago

saen acro wrote:

Rafal Kupiec wrote:

Lets say there are 2 tuners and 2 users. Everyone have set a limit of concurrent connections to 1.
This way everyone is able to watch 1 channel at once. However after enabling DVR, 1 user has the ability to watch 1 channel and record another one, thus 2nd user cannot watch anything because there is no tuner that is ready for use.

With this bug fixed, I imagine user won't be able to record one and watch another channel if this requires more 'connections' than limit set (1). But will still allow to play and record the same channel at the same time, or schedule recording (eg. at night when user is sleeping.

there is not problem to watch and record channels from same tuned transponders in same time

And who said about same transponders?
Actually 1 user can consume all tuners, preventing other users from watching TV channels. This is IMHO a bug and should be fixed.

#7

Updated by saen acro almost 10 years ago

Rafal Kupiec wrote:

And who said about same transponders?
Actually 1 user can consume all tuners, preventing other users from watching TV channels. This is IMHO a bug and should be fixed.

Agree with this, but mixing internal and external users is wrong.
So every external client should have only one connection

#8

Updated by Rafal Kupiec almost 10 years ago

saen acro wrote:

Rafal Kupiec wrote:

And who said about same transponders?
Actually 1 user can consume all tuners, preventing other users from watching TV channels. This is IMHO a bug and should be fixed.

Agree with this, but mixing internal and external users is wrong.
So every external client should have only one connection

I don't know how is this realized under the hood ;-)
I only want to say how it looks like from users point of view and that this bug might sometimes prevent other users from enabling DVR functionality...

#9

Updated by Jaroslav Kysela almost 10 years ago

  • Subject changed from Limiting number of concurrent connections per user to Limiting number of concurrent connections per user (also for DVR streaming)
#10

Updated by Rafal Kupiec over 9 years ago

Any update here?

#11

Updated by Jaroslav Kysela over 9 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset commit:tvheadend|808fd4703f5314f279c498fb7c3b148fa4805a6d.

Also available in: Atom PDF