Bug #2319
Compiler warnings on GCC 4.2.1
100%
Description
Hi,
Some of us don't have a recent OS, and still using GCC. There are currently very few compiler warnings on GCC 4.2.1 so it would be nice to fix them
tvheadend tvheadend-tvheadend-24e2c3d/ root~# gmake
CC src/version.o
CC src/uuid.o
CC src/main.o
CC src/tvhlog.o
CC src/idnode.o
CC src/prop.o
CC src/utils.o
CC src/wrappers.o
CC src/access.o
CC src/dtable.o
CC src/tcp.o
CC src/udp.o
CC src/url.o
CC src/http.o
CC src/notify.o
CC src/file.o
CC src/epg.o
CC src/epgdb.o
CC src/epggrab.o
CC src/spawn.o
CC src/packet.o
CC src/streaming.o
CC src/channels.o
CC src/subscriptions.o
CC src/service.o
CC src/htsp_server.o
CC src/htsmsg.o
CC src/htsmsg_binary.o
CC src/htsmsg_json.o
CC src/htsmsg_xml.o
CC src/misc/dbl.o
CC src/misc/json.o
CC src/settings.o
CC src/htsbuf.o
CC src/trap.o
CC src/avg.o
CC src/htsstr.o
CC src/tvhpoll.o
CC src/huffman.o
CC src/filebundle.o
CC src/config.o
CC src/lang_codes.o
CC src/lang_str.o
CC src/imagecache.o
CC src/tvhtime.o
CC src/service_mapper.o
CC src/input.o
CC src/httpc.o
CC src/rtsp.o
CC src/fsmonitor.o
CC src/cron.o
CC src/esfilter.o
CC src/intlconv.o
src/intlconv.c: In function 'intlconv_utf8':
src/intlconv.c:129: warning: passing argument 2 of 'libiconv' from incompatible pointer type
CC src/api.o
CC src/api/api_status.o
CC src/api/api_idnode.o
CC src/api/api_input.o
CC src/api/api_channel.o
CC src/api/api_service.o
CC src/api/api_mpegts.o
CC src/api/api_epg.o
CC src/api/api_epggrab.o
CC src/api/api_imagecache.o
CC src/api/api_esfilter.o
CC src/api/api_intlconv.o
CC src/api/api_access.o
CC src/api/api_dvr.o
CC src/parsers/parsers.o
CC src/parsers/bitstream.o
CC src/parsers/parser_h264.o
CC src/parsers/parser_latm.o
CC src/parsers/parser_avc.o
CC src/parsers/parser_teletext.o
CC src/epggrab/module.o
CC src/epggrab/channel.o
CC src/epggrab/module/pyepg.o
CC src/epggrab/module/xmltv.o
CC src/plumbing/tsfix.o
CC src/plumbing/globalheaders.o
CC src/dvr/dvr_db.o
CC src/dvr/dvr_rec.o
CC src/dvr/dvr_autorec.o
CC src/dvr/dvr_timerec.o
CC src/dvr/dvr_config.o
CC src/dvr/dvr_cutpoints.o
CC src/webui/webui.o
CC src/webui/comet.o
CC src/webui/extjs.o
CC src/webui/simpleui.o
CC src/webui/statedump.o
CC src/webui/html.o
CC src/webui/webui_api.o
CC src/muxer.o
CC src/muxer/muxer_pass.o
CC src/muxer/muxer_tvh.o
CC src/muxer/tvh/ebml.o
CC src/muxer/tvh/mkmux.o
CC src/upnp.o
CC src/descrambler/descrambler.o
CC src/input/mpegts.o
CC src/input/mpegts/mpegts_input.o
CC src/input/mpegts/mpegts_network.o
CC src/input/mpegts/mpegts_mux.o
CC src/input/mpegts/mpegts_service.o
CC src/input/mpegts/mpegts_table.o
CC src/input/mpegts/dvb_support.o
src/input/mpegts/dvb_support.c: In function 'code_convert':
src/input/mpegts/dvb_support.c:53: warning: passing argument 2 of 'libiconv' from incompatible pointer type
CC src/input/mpegts/dvb_charset.o
CC src/input/mpegts/dvb_psi.o
CC src/input/mpegts/tsdemux.o
CC src/input/mpegts/mpegts_mux_sched.o
CC src/input/mpegts/mpegts_network_scan.o
CC src/input/mpegts/mpegts_network_dvb.o
CC src/input/mpegts/mpegts_mux_dvb.o
CC src/input/mpegts/scanfile.o
CC src/epggrab/otamux.o
CC src/epggrab/module/eit.o
CC src/epggrab/support/freesat_huffman.o
CC src/epggrab/module/opentv.o
CC src/input/mpegts/linuxdvb/linuxdvb.o
CC src/input/mpegts/linuxdvb/linuxdvb_adapter.o
CC src/input/mpegts/linuxdvb/linuxdvb_frontend.o
CC src/input/mpegts/linuxdvb/linuxdvb_satconf.o
CC src/input/mpegts/linuxdvb/linuxdvb_lnb.o
CC src/input/mpegts/linuxdvb/linuxdvb_switch.o
CC src/input/mpegts/linuxdvb/linuxdvb_rotor.o
CC src/input/mpegts/linuxdvb/linuxdvb_en50494.o
CC src/input/mpegts/satip/satip.o
CC src/input/mpegts/satip/satip_frontend.o
CC src/input/mpegts/satip/satip_satconf.o
CC src/input/mpegts/satip/satip_rtsp.o
CC src/input/mpegts/iptv/iptv.o
CC src/input/mpegts/iptv/iptv_mux.o
CC src/input/mpegts/iptv/iptv_service.o
CC src/input/mpegts/iptv/iptv_http.o
CC src/input/mpegts/iptv/iptv_udp.o
CC src/input/mpegts/tsfile/tsfile.o
CC src/input/mpegts/tsfile/tsfile_input.o
CC src/input/mpegts/tsfile/tsfile_mux.o
CC src/timeshift.o
CC src/timeshift/timeshift_filemgr.o
CC src/timeshift/timeshift_writer.o
CC src/timeshift/timeshift_reader.o
CC src/avahi.o
CC src/libav.o
CC src/muxer/muxer_libav.o
CC src/plumbing/transcoding.o
CC src/descrambler/tvhcsa.o
CC src/descrambler/cwc.o
CC src/descrambler/capmt.o
src/descrambler/capmt.c: In function 'capmt_set_filter':
src/descrambler/capmt.c:842: warning: comparison is always false due to limited range of data type
CC src/descrambler/libaesdec/libaesdec.o
CC src/dbus.o
CC tvheadend
tvheadend tvheadend-tvheadend-24e2c3d/ root~# cc --version
cc (GCC) 4.2.1 20070831 patched [FreeBSD]
Copyright (C) 2007 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
tvheadend tvheadend-tvheadend-24e2c3d/ root~#
History
Updated by Jaroslav Kysela about 10 years ago
Fixed the descrambler warning, but for iconv, FreeBSD version differs:
size_t iconv (iconv_t cd, const char* * inbuf, size_t * inbytesleft, char* * outbuf, size_t * outbytesleft);
Linux:
size_t iconv(iconv_t cd, char **inbuf, size_t *inbytesleft, char **outbuf, size_t *outbytesleft);
Another PLATFORM_FREEBSD condition is required to fix this..
Updated by Jaroslav Kysela about 10 years ago
- Status changed from New to Fixed
- % Done changed from 0 to 100
Applied in changeset commit:tvheadend|4faa0efc8741ff778543cc478f92c1090fd95a82.